Change in coreboot[master]: soc/amd/common/gpio: Clear interrupt and wake status when configuring...

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Furquan Shaikh (Code Review)

29 Jun 2020 29 Jun '20

7:33 p.m.

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42877 )

Change subject: soc/amd/common/gpio: Clear interrupt and wake status when configuring pads ......................................................................

soc/amd/common/gpio: Clear interrupt and wake status when configuring pads

This change clears interrupt and wake status for a pad when configuring it. This ensures that stale interrupts/wake notifications are flushed out and do not cause spurious wakes in future suspends.

BUG=b:159944426

Change-Id: Ia4ebd975312a4136f1d0690d7af7372615e31f0f Signed-off-by: Furquan Shaikh furquan@google.com --- M src/soc/amd/common/block/gpio_banks/gpio.c 1 file changed, 3 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/42877/1

diff --git a/src/soc/amd/common/block/gpio_banks/gpio.c b/src/soc/amd/common/block/gpio_banks/gpio.c index a8b11ba..396846d 100644 --- a/src/soc/amd/common/block/gpio_banks/gpio.c +++ b/src/soc/amd/common/block/gpio_banks/gpio.c @@ -201,6 +201,9 @@ iomux_read8(gpio); /* Flush posted write */

soc_gpio_hook(gpio, mux); + + /* Clear interrupt and wake status (write 1-to-clear bits) */ + control |= GPIO_INT_STATUS | GPIO_WAKE_STATUS; gpio_write32(gpio, control);

if (control_flags == 0)

Attachments:

attachment.htm (text/html — 2.7 KB)

Show replies by date

Kyösti Mälkki (Code Review)

29 Jun 29 Jun

10:32 p.m.

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42877 )

Change subject: soc/amd/common/gpio: Clear interrupt and wake status when configuring pads ......................................................................

Patch Set 3: Code-Review+1

Raul Rangel (Code Review)

30 Jun 30 Jun

12:40 a.m.

Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42877 )

Change subject: soc/amd/common/gpio: Clear interrupt and wake status when configuring pads ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42877/4/src/soc/amd/common/block/gp... File src/soc/amd/common/block/gpio_banks/gpio.c:

https://review.coreboot.org/c/coreboot/+/42877/4/src/soc/amd/common/block/gp... PS4, Line 206: GPIO_WAKE_STATUS Don't we reconfigure pins on S3 resume? Don't we want the wake status so that wake source reporting works correctly?

Furquan Shaikh (Code Review)

6:40 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42877 )

Change subject: soc/amd/common/gpio: Clear interrupt and wake status when configuring pads ......................................................................

Patch Set 4: Code-Review-2

(1 comment)

Waiting for a resolution on the event-logging situation before moving ahead with this.

https://review.coreboot.org/c/coreboot/+/42877/4/src/soc/amd/common/block/gp... File src/soc/amd/common/block/gpio_banks/gpio.c:

https://review.coreboot.org/c/coreboot/+/42877/4/src/soc/amd/common/block/gp... PS4, Line 206: GPIO_WAKE_STATUS

...

Don't we reconfigure pins on S3 resume? Don't we want the wake status so that wake source reporting […]

Thanks for highlighting that Raul! I had that in mind, but didn't get a chance to sync up with Aaron on his work for eventlogging. I have added a comment here: b/159947207

-- To view, visit https://review.coreboot.org/c/coreboot/+/42877 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia4ebd975312a4136f1d0690d7af7372615e31f0f Gerrit-Change-Number: 42877 Gerrit-PatchSet: 4 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 30 Jun 2020 16:40:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Raul Rangel rrangel@chromium.org Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

7:43 p.m.

Hello build bot (Jenkins), Raul Rangel, Kyösti Mälkki, Aaron Durbin,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42877

to look at the new patch set (#5).

Change subject: soc/amd/common/gpio: Clear interrupt and wake status when configuring pads ......................................................................

soc/amd/common/gpio: Clear interrupt and wake status when configuring pads

This change clears interrupt and wake status for a pad when configuring it. This ensures that stale interrupts/wake notifications are flushed out and do not cause spurious wakes in future suspends.

BUG=b:159944426

Change-Id: Ia4ebd975312a4136f1d0690d7af7372615e31f0f Signed-off-by: Furquan Shaikh furquan@google.com --- M src/soc/amd/common/block/gpio_banks/gpio.c 1 file changed, 4 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/42877/5

build bot (Jenkins) (Code Review)

8:46 p.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42877 )

Change subject: soc/amd/common/gpio: Clear interrupt and wake status when configuring pads ......................................................................

Patch Set 5:

(3 comments)

https://review.coreboot.org/c/coreboot/+/42877/5/src/soc/amd/common/block/gp... File src/soc/amd/common/block/gpio_banks/gpio.c:

https://review.coreboot.org/c/coreboot/+/42877/5/src/soc/amd/common/block/gp... PS5, Line 213: __gpio_setbits32(gpio, PAD_CFG_MASK, control); code indent should use tabs where possible

https://review.coreboot.org/c/coreboot/+/42877/5/src/soc/amd/common/block/gp... PS5, Line 213: __gpio_setbits32(gpio, PAD_CFG_MASK, control); please, no space before tabs

https://review.coreboot.org/c/coreboot/+/42877/5/src/soc/amd/common/block/gp... PS5, Line 213: __gpio_setbits32(gpio, PAD_CFG_MASK, control); please, no spaces at the start of a line

-- To view, visit https://review.coreboot.org/c/coreboot/+/42877 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia4ebd975312a4136f1d0690d7af7372615e31f0f Gerrit-Change-Number: 42877 Gerrit-PatchSet: 5 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 30 Jun 2020 18:46:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Aaron Durbin (Code Review)

9:25 p.m.

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42877 )

Change subject: soc/amd/common/gpio: Clear interrupt and wake status when configuring pads ......................................................................

Patch Set 6: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/42877 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia4ebd975312a4136f1d0690d7af7372615e31f0f Gerrit-Change-Number: 42877 Gerrit-PatchSet: 6 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 30 Jun 2020 19:25:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

build bot (Jenkins) (Code Review)

10:16 p.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42877 )

Change subject: soc/amd/common/gpio: Clear interrupt and wake status when configuring pads ......................................................................

Patch Set 6:

(3 comments)

https://review.coreboot.org/c/coreboot/+/42877/6/src/soc/amd/common/block/gp... File src/soc/amd/common/block/gpio_banks/gpio.c:

https://review.coreboot.org/c/coreboot/+/42877/6/src/soc/amd/common/block/gp... PS6, Line 213: __gpio_setbits32(gpio, PAD_CFG_MASK, control); code indent should use tabs where possible

https://review.coreboot.org/c/coreboot/+/42877/6/src/soc/amd/common/block/gp... PS6, Line 213: __gpio_setbits32(gpio, PAD_CFG_MASK, control); please, no space before tabs

https://review.coreboot.org/c/coreboot/+/42877/6/src/soc/amd/common/block/gp... PS6, Line 213: __gpio_setbits32(gpio, PAD_CFG_MASK, control); please, no spaces at the start of a line

-- To view, visit https://review.coreboot.org/c/coreboot/+/42877 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia4ebd975312a4136f1d0690d7af7372615e31f0f Gerrit-Change-Number: 42877 Gerrit-PatchSet: 6 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 30 Jun 2020 20:16:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

1 Jul 1 Jul

12:58 a.m.

Hello build bot (Jenkins), Raul Rangel, Kyösti Mälkki, Aaron Durbin,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42877

to look at the new patch set (#7).

Change subject: soc/amd/common/gpio: Clear interrupt and wake status when configuring pads ......................................................................

soc/amd/common/gpio: Clear interrupt and wake status when configuring pads

This change clears interrupt and wake status for a pad when configuring it. This ensures that stale interrupts/wake notifications are flushed out and do not cause spurious wakes in future suspends.

BUG=b:159944426

Change-Id: Ia4ebd975312a4136f1d0690d7af7372615e31f0f Signed-off-by: Furquan Shaikh furquan@google.com --- M src/soc/amd/common/block/gpio_banks/gpio.c 1 file changed, 3 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/42877/7

Furquan Shaikh (Code Review)

12:58 a.m.

Furquan Shaikh has removed a vote from this change. ( https://review.coreboot.org/c/coreboot/+/42877 )

Change subject: soc/amd/common/gpio: Clear interrupt and wake status when configuring pads ......................................................................

Removed Code-Review-2 by Furquan Shaikh furquan@google.com

Furquan Shaikh (Code Review)

12:59 a.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42877 )

Change subject: soc/amd/common/gpio: Clear interrupt and wake status when configuring pads ......................................................................

Patch Set 7:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42877/4/src/soc/amd/common/block/gp... File src/soc/amd/common/block/gpio_banks/gpio.c:

https://review.coreboot.org/c/coreboot/+/42877/4/src/soc/amd/common/block/gp... PS4, Line 206: GPIO_WAKE_STATUS

...

Thanks for highlighting that Raul! I had that in mind, but didn't get a chance to sync up with Aaron […]

This will be taken care of in the event logging change to ensure that we snapshot the state before getting to the point of clearing the wake status.

-- To view, visit https://review.coreboot.org/c/coreboot/+/42877 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia4ebd975312a4136f1d0690d7af7372615e31f0f Gerrit-Change-Number: 42877 Gerrit-PatchSet: 7 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 30 Jun 2020 22:59:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Raul Rangel rrangel@chromium.org Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Aaron Durbin (Code Review)

1:13 a.m.

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42877 )

Change subject: soc/amd/common/gpio: Clear interrupt and wake status when configuring pads ......................................................................

Patch Set 7: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/42877 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia4ebd975312a4136f1d0690d7af7372615e31f0f Gerrit-Change-Number: 42877 Gerrit-PatchSet: 7 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 30 Jun 2020 23:13:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

1:31 a.m.

Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42877 )

Change subject: soc/amd/common/gpio: Clear interrupt and wake status when configuring pads ......................................................................

soc/amd/common/gpio: Clear interrupt and wake status when configuring pads

This change clears interrupt and wake status for a pad when configuring it. This ensures that stale interrupts/wake notifications are flushed out and do not cause spurious wakes in future suspends.

BUG=b:159944426

Change-Id: Ia4ebd975312a4136f1d0690d7af7372615e31f0f Signed-off-by: Furquan Shaikh furquan@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/42877 Reviewed-by: Aaron Durbin adurbin@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/amd/common/block/gpio_banks/gpio.c 1 file changed, 3 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved

diff --git a/src/soc/amd/common/block/gpio_banks/gpio.c b/src/soc/amd/common/block/gpio_banks/gpio.c index 883dcfa..ebb2936 100644 --- a/src/soc/amd/common/block/gpio_banks/gpio.c +++ b/src/soc/amd/common/block/gpio_banks/gpio.c @@ -207,6 +207,9 @@ iomux_read8(gpio); /* Flush posted write */

soc_gpio_hook(gpio, mux); + + /* Clear interrupt and wake status (write 1-to-clear bits) */ + control |= GPIO_INT_STATUS | GPIO_WAKE_STATUS; __gpio_setbits32(gpio, PAD_CFG_MASK, control);

if (control_flags == 0)

Aaron Durbin (Code Review)

30 Jul 30 Jul

12:13 a.m.

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42877 )

Change subject: soc/amd/common/gpio: Clear interrupt and wake status when configuring pads ......................................................................

Patch Set 8:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42877/4/src/soc/amd/common/block/gp... File src/soc/amd/common/block/gpio_banks/gpio.c:

https://review.coreboot.org/c/coreboot/+/42877/4/src/soc/amd/common/block/gp... PS4, Line 206: GPIO_WAKE_STATUS

...

This will be taken care of in the event logging change to ensure that we snapshot the state before g […]

I think we'd be able to log (eventlog) things w/ b/159947207 once that work is done, but it doesn't handle the case of the kernel expecting to capture the wake. If we want to note the device that woke from kernel we shouldn't clear these.

-- To view, visit https://review.coreboot.org/c/coreboot/+/42877 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia4ebd975312a4136f1d0690d7af7372615e31f0f Gerrit-Change-Number: 42877 Gerrit-PatchSet: 8 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 29 Jul 2020 22:13:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Raul Rangel rrangel@chromium.org Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

5 a.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42877 )

Change subject: soc/amd/common/gpio: Clear interrupt and wake status when configuring pads ......................................................................

Patch Set 8:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42877/4/src/soc/amd/common/block/gp... File src/soc/amd/common/block/gpio_banks/gpio.c:

https://review.coreboot.org/c/coreboot/+/42877/4/src/soc/amd/common/block/gp... PS4, Line 206: GPIO_WAKE_STATUS

...

I think we'd be able to log (eventlog) things w/ b/159947207 once that work is done, but it doesn't […]

I will have to dig into the kernel driver to see how it handles the WAKE_STATUS. But I agree that in general the kernel might want to send pm_wakeup notification depending upon the WAKE_STATUS bits.

-- To view, visit https://review.coreboot.org/c/coreboot/+/42877 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia4ebd975312a4136f1d0690d7af7372615e31f0f Gerrit-Change-Number: 42877 Gerrit-PatchSet: 8 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 30 Jul 2020 03:00:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Raul Rangel rrangel@chromium.org Comment-In-Reply-To: Furquan Shaikh furquan@google.com Comment-In-Reply-To: Aaron Durbin adurbin@chromium.org Gerrit-MessageType: comment

Raul Rangel (Code Review)

4:55 p.m.

Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42877 )

Change subject: soc/amd/common/gpio: Clear interrupt and wake status when configuring pads ......................................................................

Patch Set 8:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42877/4/src/soc/amd/common/block/gp... File src/soc/amd/common/block/gpio_banks/gpio.c:

https://review.coreboot.org/c/coreboot/+/42877/4/src/soc/amd/common/block/gp... PS4, Line 206: GPIO_WAKE_STATUS

...

I will have to dig into the kernel driver to see how it handles the WAKE_STATUS. […]

We should run the dark resume test. I'm pretty sure that relies on these values.

-- To view, visit https://review.coreboot.org/c/coreboot/+/42877 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia4ebd975312a4136f1d0690d7af7372615e31f0f Gerrit-Change-Number: 42877 Gerrit-PatchSet: 8 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 30 Jul 2020 14:55:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Raul Rangel rrangel@chromium.org Comment-In-Reply-To: Furquan Shaikh furquan@google.com Comment-In-Reply-To: Aaron Durbin adurbin@chromium.org Gerrit-MessageType: comment

1559

days inactive

1590

days old

coreboot-gerrit@coreboot.org

15 comments

5 participants

tags (0)

participants (5)

Aaron Durbin (Code Review)
build bot (Jenkins) (Code Review)
Furquan Shaikh (Code Review)
Kyösti Mälkki (Code Review)
Raul Rangel (Code Review)