Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73811 )
Change subject: mb/asrock/b75pro3-m: Disable unused ME KT PCI device ......................................................................
Patch Set 5:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/73811/comment/69a7a834_6539f6da PS3, Line 11: Disable the device, as it obviously doesn't exist (at that address).
Done
The B-prefix PCHs don't have as much "corporate ME" functionality as the Q-prefix PCHs, but they come with some things. These might not be used on the B75 Pro3-M because of the Realtek NIC, though.
Patchset:
PS5:
Felix, this was submitted too early.
https://doc.coreboot.org/contributing/gerrit_guidelines.html doesn't list any reason why this patch may be submitted early. It's not trivial (small != trivial) given that there was an open discussion (when a patch is trivial, nothing needs to be discussed), nor fixes a recently-introduced issue. Is 24 hours that long of a waiting period?
It's not like the world is going to end because this patch got submitted too early, but please try to keep this in mind for the future. Asking a complex question during review only to find that the patch in question has already been submitted a few hours later makes it feel as if the time spent reviewing was in vain.
-
Angel Pons (Code Review)