Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30397 )
Change subject: [WIP] mb/lenovo/dock.asl: Add proper dock support ......................................................................
Patch Set 1:
(3 comments)
Looks good, but could need more comments, to make it easier to compare with c code
https://review.coreboot.org/#/c/30397/1/src/mainboard/lenovo/t400/acpi/dock.... File src/mainboard/lenovo/t400/acpi/dock.asl:
https://review.coreboot.org/#/c/30397/1/src/mainboard/lenovo/t400/acpi/dock.... PS1, Line 140: OperationRegion (NSIO, SystemIO, DLPC_GPIO_BASE, 0x0C) why is the pc87382 on the DOCK device, it's located on the mainboard ?
https://review.coreboot.org/#/c/30397/1/src/mainboard/lenovo/t400/acpi/dock.... PS1, Line 167: Name (G_ID, 0xffffffff) Ones
https://review.coreboot.org/#/c/30397/1/src/mainboard/lenovo/t400/acpi/dock.... PS1, Line 191: If ((_SB.DOCK.GGID () == 0x01)) DOCK_TYPE_2504