build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30414 )
Change subject: mainboard/facebook/fbg1701: Do initial mainboard commit ......................................................................
Patch Set 1:
(22 comments)
https://review.coreboot.org/#/c/30414/1/src/mainboard/facebook/fbg1701/board... File src/mainboard/facebook/fbg1701/board_verified_boot.c:
https://review.coreboot.org/#/c/30414/1/src/mainboard/facebook/fbg1701/board... PS1, Line 41: { VERIFY_FILE, FSP, { { NULL, CBFS_TYPE_FSP}}, HASH_IDX_FSP, space required after that close brace '}'
https://review.coreboot.org/#/c/30414/1/src/mainboard/facebook/fbg1701/board... PS1, Line 72: void car_mainboard_post_console_init(void) { open brace '{' following function definitions go on the next line
https://review.coreboot.org/#/c/30414/1/src/mainboard/facebook/fbg1701/board... PS1, Line 79: if (IS_ENABLED(CONFIG_VERIFIED_BOOT) && suspect code indent for conditional statements (8, 24)
https://review.coreboot.org/#/c/30414/1/src/mainboard/facebook/fbg1701/board... PS1, Line 100: VERIFIED_BOOT_COPY_BLOCK}}, HASH_IDX_PAYLOAD, space required after that close brace '}'
https://review.coreboot.org/#/c/30414/1/src/mainboard/facebook/fbg1701/board... PS1, Line 102: {VERIFY_TERMINATOR, NULL, {{NULL, 0}}, 0, 0} space required after that close brace '}'
https://review.coreboot.org/#/c/30414/1/src/mainboard/facebook/fbg1701/board... PS1, Line 106: {VERIFY_TERMINATOR, NULL, {{NULL, 0}}, 0, 0} space required after that close brace '}'
https://review.coreboot.org/#/c/30414/1/src/mainboard/facebook/fbg1701/irqro... File src/mainboard/facebook/fbg1701/irqroute.h:
https://review.coreboot.org/#/c/30414/1/src/mainboard/facebook/fbg1701/irqro... PS1, Line 40: #define PCI_DEV_PIRQ_ROUTES \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/#/c/30414/1/src/mainboard/facebook/fbg1701/irqro... PS1, Line 62: #define PIRQ_PIC_ROUTES \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/#/c/30414/1/src/mainboard/facebook/fbg1701/mainb... File src/mainboard/facebook/fbg1701/mainboard.c:
https://review.coreboot.org/#/c/30414/1/src/mainboard/facebook/fbg1701/mainb... PS1, Line 27: void mainboard_configure_edp_bridge(void) { open brace '{' following function definitions go on the next line
https://review.coreboot.org/#/c/30414/1/src/mainboard/facebook/fbg1701/mainb... PS1, Line 52: struct resource * res; "foo * bar" should be "foo *bar"
https://review.coreboot.org/#/c/30414/1/src/mainboard/facebook/fbg1701/onboa... File src/mainboard/facebook/fbg1701/onboard.h:
https://review.coreboot.org/#/c/30414/1/src/mainboard/facebook/fbg1701/onboa... PS1, Line 29: #define ITE8528_CMD_PORT 0x6E please, no space before tabs
https://review.coreboot.org/#/c/30414/1/src/mainboard/facebook/fbg1701/onboa... PS1, Line 30: #define ITE8528_DATA_PORT 0x6F please, no space before tabs
https://review.coreboot.org/#/c/30414/1/src/mainboard/facebook/fbg1701/onboa... PS1, Line 38: #define FSP (const char*) "fsp.bin" "(foo*)" should be "(foo *)"
https://review.coreboot.org/#/c/30414/1/src/mainboard/facebook/fbg1701/onboa... PS1, Line 39: #define CMOS_LAYOUT (const char*) "cmos_layout.bin" "(foo*)" should be "(foo *)"
https://review.coreboot.org/#/c/30414/1/src/mainboard/facebook/fbg1701/onboa... PS1, Line 40: #define RAMSTAGE (const char*) "fallback/ramstage" "(foo*)" should be "(foo *)"
https://review.coreboot.org/#/c/30414/1/src/mainboard/facebook/fbg1701/onboa... PS1, Line 41: #define ROMSTAGE (const char*) "fallback/romstage" "(foo*)" should be "(foo *)"
https://review.coreboot.org/#/c/30414/1/src/mainboard/facebook/fbg1701/onboa... PS1, Line 42: #define PAYLOAD (const char*) "fallback/payload" "(foo*)" should be "(foo *)"
https://review.coreboot.org/#/c/30414/1/src/mainboard/facebook/fbg1701/onboa... PS1, Line 43: #define OP_ROM_VBT (const char*) "vbt.bin" "(foo*)" should be "(foo *)"
https://review.coreboot.org/#/c/30414/1/src/mainboard/facebook/fbg1701/onboa... PS1, Line 44: #define MICROCODE (const char*) "cpu_microcode_blob.bin" "(foo*)" should be "(foo *)"
https://review.coreboot.org/#/c/30414/1/src/mainboard/facebook/fbg1701/romst... File src/mainboard/facebook/fbg1701/romstage.c:
https://review.coreboot.org/#/c/30414/1/src/mainboard/facebook/fbg1701/romst... PS1, Line 81: static const uint8_t crtm_version[] = CONFIG_CRTM_VERSION_STRING \ Avoid unnecessary line continuations
https://review.coreboot.org/#/c/30414/1/src/mainboard/facebook/fbg1701/romst... PS1, Line 95: printk(BIOS_DEBUG, "%s: EventSize - %u\n", __func__ , space prohibited before that ',' (ctx:WxE)
https://review.coreboot.org/#/c/30414/1/src/mainboard/facebook/fbg1701/romst... PS1, Line 103: printk (BIOS_DEBUG, "Measure CRTM Version returned 0x%x\n", space prohibited between function name and open parenthesis '('