Change in coreboot[master]: soc/intel/common: Add bootblock common stage file

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/18457 )

Change subject: soc/intel/common: Add bootblock common stage file
......................................................................

Patch Set 38:

(2 comments)

https://review.coreboot.org/c/coreboot/+/18457/37/src/soc/intel/common/basec... 
File src/soc/intel/common/basecode/bootblock/bootblock.c:

https://review.coreboot.org/c/coreboot/+/18457/37/src/soc/intel/common/basec... 
PS37, Line 39: bootblock_soc_early_init(void)
> I think this is just to allow arbitrary function names. […]

The platform you mention doesn't support this kind of runtime detection. You have to specify the exact generation, otherwise it won't boot. For example:
* It doesn't include all microcodes 
* It has 3 different FSP for 4 different socs

https://review.coreboot.org/c/coreboot/+/18457/37/src/soc/intel/common/basec... 
PS37, Line 102: (CONFIG(PAGING_IN_CACHE_AS_RAM))
> I think APL/GLK differ too much from the big core platforms to have common code everywhere. […]

you consider 3 lines of code as too different?