Attention is currently required from: Furquan Shaikh, Subrata Banik, Patrick Rudolph, EricR Lai.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51460 )
Change subject: soc/intel/alderlake: Add Kconfig for recommended PCIe TBT resources
......................................................................
Patch Set 1:
(3 comments)
File src/soc/intel/alderlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/51460/comment/6b4a2553_58900b66
PS1, Line 138: ADL_MAINBOARD_SUPPORTS_PCIEXP_HOTPLUG
Just thinking some more. […]
That name is much better!
https://review.coreboot.org/c/coreboot/+/51460/comment/61c3de08_5a7498a4
PS1, Line 142: config PCIEXP_HOTPLUG_BUSES
nit: if you use: […]
Sure 😊
https://review.coreboot.org/c/coreboot/+/51460/comment/81282b58_70069284
PS1, Line 143:
Use tab instead of spaces here and in the lines below.
Thought I ran `M-x tabify` on it... 🤓
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51460
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icdfa2688d69c2db0f98d0523d5aba42eec1824db
Gerrit-Change-Number: 51460
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Fri, 12 Mar 2021 20:36:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment