Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31020
Change subject: src/mb/asrock/../g41m-s3: Remove spurious devices ......................................................................
src/mb/asrock/../g41m-s3: Remove spurious devices
This fixes errors regarding "PCI: Leftover static devices"
Change-Id: Ie45fe6934df4a9dad4c8f6b1af665034853c4c5a Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/asrock/g41c-gs/variants/g41m-s3/devicetree.cb 1 file changed, 0 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/31020/1
diff --git a/src/mainboard/asrock/g41c-gs/variants/g41m-s3/devicetree.cb b/src/mainboard/asrock/g41c-gs/variants/g41m-s3/devicetree.cb index cdcadba..971eebd7 100644 --- a/src/mainboard/asrock/g41c-gs/variants/g41m-s3/devicetree.cb +++ b/src/mainboard/asrock/g41c-gs/variants/g41m-s3/devicetree.cb @@ -33,8 +33,6 @@ device pci 2.0 on # Integrated graphics controller subsystemid 0x1849 0x2e32 end - device pci 3.0 off end # ME - device pci 3.1 off end # ME chip southbridge/intel/i82801gx # Southbridge register "pirqa_routing" = "0x0b" register "pirqb_routing" = "0x0b" @@ -140,9 +138,6 @@ device pci 1f.3 on # SMbus subsystemid 0x1849 0x27da end - device pci 1f.4 off end - device pci 1f.5 off end - device pci 1f.6 off end end end end
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31020 )
Change subject: src/mb/asrock/../g41m-s3: Remove spurious devices ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/31020/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31020/1//COMMIT_MSG@10 PS1, Line 10: So there are no such static devices on the board, right?
https://review.coreboot.org/#/c/31020/1/src/mainboard/asrock/g41c-gs/variant... File src/mainboard/asrock/g41c-gs/variants/g41m-s3/devicetree.cb:
https://review.coreboot.org/#/c/31020/1/src/mainboard/asrock/g41c-gs/variant... PS1, Line 37: Doesn’t that board have an Intel ME?
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31020 )
Change subject: src/mb/asrock/../g41m-s3: Remove spurious devices ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/31020/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31020/1//COMMIT_MSG@10 PS1, Line 10:
So there are no such static devices on the board, right?
I think so
https://review.coreboot.org/#/c/31020/1/src/mainboard/asrock/g41c-gs/variant... File src/mainboard/asrock/g41c-gs/variants/g41m-s3/devicetree.cb:
https://review.coreboot.org/#/c/31020/1/src/mainboard/asrock/g41c-gs/variant... PS1, Line 37:
Doesn’t that board have an Intel ME?
Not that I know of. The vendor FW does not even have an IFD.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31020 )
Change subject: src/mb/asrock/../g41m-s3: Remove spurious devices ......................................................................
Patch Set 1: Code-Review+2
Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31020 )
Change subject: src/mb/asrock/../g41m-s3: Remove spurious devices ......................................................................
src/mb/asrock/../g41m-s3: Remove spurious devices
This fixes errors regarding "PCI: Leftover static devices"
Change-Id: Ie45fe6934df4a9dad4c8f6b1af665034853c4c5a Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/31020 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de --- M src/mainboard/asrock/g41c-gs/variants/g41m-s3/devicetree.cb 1 file changed, 0 insertions(+), 5 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/src/mainboard/asrock/g41c-gs/variants/g41m-s3/devicetree.cb b/src/mainboard/asrock/g41c-gs/variants/g41m-s3/devicetree.cb index cdcadba..971eebd7 100644 --- a/src/mainboard/asrock/g41c-gs/variants/g41m-s3/devicetree.cb +++ b/src/mainboard/asrock/g41c-gs/variants/g41m-s3/devicetree.cb @@ -33,8 +33,6 @@ device pci 2.0 on # Integrated graphics controller subsystemid 0x1849 0x2e32 end - device pci 3.0 off end # ME - device pci 3.1 off end # ME chip southbridge/intel/i82801gx # Southbridge register "pirqa_routing" = "0x0b" register "pirqb_routing" = "0x0b" @@ -140,9 +138,6 @@ device pci 1f.3 on # SMbus subsystemid 0x1849 0x27da end - device pci 1f.4 off end - device pci 1f.5 off end - device pci 1f.6 off end end end end
-
Angel Pons (Code Review) -
Nico Huber (Code Review)
-
Paul Menzel (Code Review)