Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39523 )
Change subject: util/inteltool: add code for dumping APIC registers ......................................................................
Patch Set 6: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/39523/6/util/inteltool/apic.c File util/inteltool/apic.c:
https://review.coreboot.org/c/coreboot/+/39523/6/util/inteltool/apic.c@92 PS6, Line 92: = Space needed here
https://review.coreboot.org/c/coreboot/+/39523/6/util/inteltool/apic.c@95 PS6, Line 95: apicbase+ Isn't this redundant?
https://review.coreboot.org/c/coreboot/+/39523/6/util/inteltool/apic.c@107 PS6, Line 107: = Space needed here