Attention is currently required from: Hung-Te Lin, Kei Hiroyoshi, Yu-Ping Wu.
Varshit Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81218?usp=email )
Change subject: mb/google/corsola: Add new board 'Kyogre'
......................................................................
Patch Set 6:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81218/comment/dab43560_63b58b28 :
PS6, Line 20:
I would remove this extra line, also I'd put "signed-off" line after "Change-ID"
for reference you can look at any recent merged patch.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81218?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iae3857a9f8edadcc2eee3500fda2e76c0334221c
Gerrit-Change-Number: 81218
Gerrit-PatchSet: 6
Gerrit-Owner: Kei Hiroyoshi
hiroyoshi.kei@fujitsu.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kenny Pan
kennypan@google.com
Gerrit-CC: Knox Chiou
knoxchiou@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Kei Hiroyoshi
hiroyoshi.kei@fujitsu.corp-partner.google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Wed, 27 Mar 2024 12:20:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment