Attention is currently required from: Robert Zieba, Raul Rangel, Paul Menzel, Reka Norman, Nick Vaccaro, Felix Held.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62905 )
Change subject: util/spd_tools: Add support for exclusive IDs
......................................................................
Patch Set 8:
(1 comment)
Patchset:
PS8:
i'm not sure if this is the correct approach or if this and the next one just adds a workaround arou […]
This change is not impacting the default behavior of the SPD generation tool or SPD ID generation tool. This change just updates the tool to use the hint from the mainboard/variant to reserve certain SPD IDs exclusively. There has been precedence in the past.
This support is required because of the ABL requirement to train memory with specific tuning values for certain memory parts eventhough their characteristics is identical to other parts. It is not identifying single vs dual rank memory parts. Rather it is about training certain(not all) Samsung parts with specific tuning values.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62905
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ife5afe32337f69bc06451ce16238c7a83bc983c8
Gerrit-Change-Number: 62905
Gerrit-PatchSet: 8
Gerrit-Owner: Robert Zieba
robertzieba@google.com
Gerrit-Reviewer: Bhanu Prakash Maiya
bhanumaiya@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Peers
epeers@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Robert Zieba
robertzieba@google.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 21 Mar 2022 18:14:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment