[M] Change in coreboot[main]: mb/google/dedede/var/awasuki: Enable ELAN touchscreen with fw_config

[Karthik Ramasubramanian (Code Review)]

Attention is currently required from: Eric Lai, Weimin Wu.

Karthik Ramasubramanian has posted comments on this change by Weimin Wu. ( https://review.coreboot.org/c/coreboot/+/83704?usp=email )

Change subject: mb/google/dedede/var/awasuki: Enable ELAN touchscreen with fw_config
......................................................................

Patch Set 5:

(3 comments)

File src/mainboard/google/dedede/variants/awasuki/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/83704/comment/73083ec5_3b43d640?usp... :
PS5, Line 1: fw_config
           : 	field TOUCH 5
           : 		option TOUCH_ABSENT	0
           : 		option TOUCH_PRESENT	1
           : 	end
           : end
Please move this to variants/baseboard/devicetree.cb along with other fw_config. In dedede, all the programs shared the same FW_CONFIG bitfields.

Also please rename TOUCH as TOUCHSCREEN for clarity.

File src/mainboard/google/dedede/variants/awasuki/ramstage.c:

https://review.coreboot.org/c/coreboot/+/83704/comment/e96d4b24_3bb5fe3a?usp... :
PS5, Line 9: 	/* H4  : AP_I2C_TS_SDA */
           : 	PAD_NC(GPP_H4, NONE),
           : 	/* H5  : AP_I2C_TS_SCL */
           : 	PAD_NC(GPP_H5, NONE),
Also you need to configure ENABLE, Reset and Stop/Report GPIOs as NC so that they are not floating or leaking power.

https://review.coreboot.org/c/coreboot/+/83704/comment/e8dc9046_5106d6f6?usp... :
PS5, Line 24: 	if (!fw_config_probe(FW_CONFIG(TOUCH, TOUCH_PRESENT))) {
            : 		cfg->SerialIoI2cMode[PchSerialIoIndexI2C2] = PchSerialIoDisabled;
            : 	}
            : 
            : 	if (!fw_config_probe(FW_CONFIG(TOUCH, TOUCH_PRESENT))) {
            : 		printk(BIOS_INFO, "Disable TS GPIO pins.\n");
            : 		gpio_configure_pads(ts_disable_pad, ARRAY_SIZE(ts_disable_pad));
            : 	}
Both the if blocks can be combined into one.