Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/52494 )
Change subject: mb/google/volteer/variants/copano: Fix pen ejection event ......................................................................
mb/google/volteer/variants/copano: Fix pen ejection event
Modify PENH device GPIO GPP_E17 for pen ejection event.
BUG=b:182867209 BRANCH=firmware-volteer-13672.B TEST=emerge-volteer coreboot, check evtest if SW_PEN_INSERTED event (value:1/0) when insert/eject pen, and eject pen to wake system from s0ix
Change-Id: I1b13d09ed6d065779de9441f2137dcf6559b8f27 Signed-off-by: Hao Chou hao_chou@pegatron.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/52494 Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-by: Paul2 Huang paul2_huang@pegatron.corp-partner.google.com Reviewed-by: Zhuohao Lee zhuohao@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/volteer/variants/copano/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Zhuohao Lee: Looks good to me, but someone else must approve Tim Wawrzynczak: Looks good to me, approved Paul2 Huang: Looks good to me, but someone else must approve Hao Chou: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/volteer/variants/copano/overridetree.cb b/src/mainboard/google/volteer/variants/copano/overridetree.cb index 7c90643..b0a108e 100644 --- a/src/mainboard/google/volteer/variants/copano/overridetree.cb +++ b/src/mainboard/google/volteer/variants/copano/overridetree.cb @@ -150,7 +150,7 @@ chip drivers/generic/gpio_keys register "name" = ""PENH"" # GPP_E17 is the IRQ source, and GPP_E1 is the wake source - register "gpio" = "ACPI_GPIO_INPUT_ACTIVE_LOW(GPP_E17)" + register "gpio" = "ACPI_GPIO_INPUT_ACTIVE_HIGH(GPP_E17)" register "key.wake_gpe" = "GPE0_DW2_01" register "key.wakeup_route" = "WAKEUP_ROUTE_SCI" register "key.wakeup_event_action" = "EV_ACT_DEASSERTED"
-
Patrick Georgi (Code Review)