build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26874 )
Change subject: mb/google/octopus: Update GPIOs as per latest schematics ......................................................................
Patch Set 1:
(7 comments)
https://review.coreboot.org/#/c/26874/1/src/mainboard/google/octopus/variant... File src/mainboard/google/octopus/variants/baseboard/gpio.c:
https://review.coreboot.org/#/c/26874/1/src/mainboard/google/octopus/variant... PS1, Line 79: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_50, NONE, DEEP, NF1, HIZCRx1, DISPUPD), /* PCH_I2C_PEN_SDA */ line over 80 characters
https://review.coreboot.org/#/c/26874/1/src/mainboard/google/octopus/variant... PS1, Line 80: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_51, NONE, DEEP, NF1, HIZCRx1, DISPUPD), /* PCH_I2C_PEN_SCL */ line over 80 characters
https://review.coreboot.org/#/c/26874/1/src/mainboard/google/octopus/variant... PS1, Line 198: PAD_CFG_GPI_APIC_IOS(GPIO_138, NONE, DEEP, LEVEL, INVERT, HIZCRx1, DISPUPD),/* GPIO_138 -- PEN_PDCT_ODL */ line over 80 characters
https://review.coreboot.org/#/c/26874/1/src/mainboard/google/octopus/variant... PS1, Line 200: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_140, 1, DEEP, NONE, Tx1RXDCRx0, DISPUPD),/* GPIO_140 -- PEN_RESET */ line over 80 characters
https://review.coreboot.org/#/c/26874/1/src/mainboard/google/octopus/variant... PS1, Line 207: PAD_CFG_GPI_SCI_LOW(GPIO_144, NONE, DEEP, LEVEL),/* GPIO_144 -- PEN_EJECT_ODL(wake) */ line over 80 characters
https://review.coreboot.org/#/c/26874/1/src/mainboard/google/octopus/variant... PS1, Line 208: PAD_CFG_GPI_GPIO_DRIVER(GPIO_145, NONE, DEEP),/* GPIO_145 -- PEN_EJECT_ODL(notifications) */ line over 80 characters
https://review.coreboot.org/#/c/26874/1/src/mainboard/google/octopus/variant... PS1, Line 209: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_146, NONE, DEEP, NF5, HIZCRx0, DISPUPD),/* GPIO_146 -- NC */ line over 80 characters
-
build bot (Jenkins) (Code Review)