Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80084?usp=email )
Change subject: soc/amd/*/chip: factor out FSP-S call
......................................................................
Patch Set 1: Code-Review+2
(2 comments)
Patchset:
PS1:
Handle this the same as the fsp_s change.
File src/soc/amd/cezanne/chip.c:
https://review.coreboot.org/c/coreboot/+/80084/comment/59e1b517_00e634f0 :
PS1, Line 40: fsp_s_call
same comment as for fsp_m_call. I just don't like the "call" part. It's like naming functions "blahblahblah_func()" It just seems redundant.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80084?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic8236db7ac80275a65020b7e7a9acce8314c831c
Gerrit-Change-Number: 80084
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 18 Jan 2024 22:20:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment