Krystian Hebel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30117 )
Change subject: arch/x86: Support x86_64 exceptions
......................................................................
Patch Set 14: Code-Review+1
(1 comment)
https://review.coreboot.org/#/c/30117/13/src/arch/x86/idt.S
File src/arch/x86/idt.S:
https://review.coreboot.org/#/c/30117/13/src/arch/x86/idt.S@145
PS13, Line 145: lea 64(%rsp), %rbp
I removed this code as RSP is pushed by interrupt on stack.
Right, that works too.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30117
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idd12c90a95cc2989eb9b2a718740a84222193f48
Gerrit-Change-Number: 30117
Gerrit-PatchSet: 14
Gerrit-Owner: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 30 Apr 2019 10:45:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Krystian Hebel
krystian.hebel@3mdeb.com
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-MessageType: comment