Attention is currently required from: Sean Rhodes.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74955 )
Change subject: soc/intel/apollolake: Only use 8 bits for afterg3
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175868):
https://review.coreboot.org/c/coreboot/+/74955/comment/6bfc9514_1c667505
PS3, Line 9: In GEN_PMCON1 (Offset 1020h), Bit 0 is the "After G3 Enable" (ag3e)
Possible unwrapped commit description (prefer a maximum 72 chars per line)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74955
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idb290d1480b03cb3425edc6ff29b9c78a6545df1
Gerrit-Change-Number: 74955
Gerrit-PatchSet: 3
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Comment-Date: Wed, 10 May 2023 14:35:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment