Attention is currently required from: Tim Wawrzynczak, Rizwan Qureshi, Sumeet R Pawnikar, Eric Lai.
Varshit B Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63697 )
Change subject: drivers/intel/dptf: Add support for PROP method
......................................................................
Patch Set 1:
(3 comments)
Patchset:
PS1:
ACK, will add check in next patchset
File src/drivers/intel/dptf/dptf.c:
https://review.coreboot.org/c/coreboot/+/63697/comment/0fc5002f_45aaa818
PS1, Line 518: acpigen_write_integer(config->prop);
Please add check if this is mandatory.
Ack
https://review.coreboot.org/c/coreboot/+/63697/comment/7bdd094d_52bfc22c
PS1, Line 533: write_prop(config);
If this is no mandatory, please add check here to skip if value is 0.
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63697
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1415d2a9eb55cfadc3a7b41b53ecbec657002759
Gerrit-Change-Number: 63697
Gerrit-PatchSet: 1
Gerrit-Owner: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Poornima Tom
poornima.tom@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Mon, 18 Apr 2022 11:29:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment