Change in coreboot[master]: apple/macbook21: configure the clockgen and add C3 CPU state - coreboot-gerrit

19 Apr 2022


      Attention is currently required from: Nico Huber, Ferass EL HAFIDI, Paul Menzel, Felix Held.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63587 )
Change subject: apple/macbook21: configure the clockgen and add C3 CPU state
......................................................................
Patch Set 8:
(1 comment)
File src/mainboard/apple/macbook21/cstates.c:
https://review.coreboot.org/c/coreboot/+/63587/comment/5dd8f11b_17c0e4be 
PS4, Line 34: 		.latency = 17,
...
I guess it would be safe to just set that value to 1. Thoughts?
I'd just leave it at what the vendor set.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/63587
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib97f95599fbdf66aa55e936bdcb9cc0cd69b3824
Gerrit-Change-Number: 63587
Gerrit-PatchSet: 8
Gerrit-Owner: Ferass EL HAFIDI vitali64pmemail@protonmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Evgeny Zinoviev me@ch1p.io
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Ferass EL HAFIDI vitali64pmemail@protonmail.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 19 Apr 2022 17:13:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Comment-In-Reply-To: Ferass EL HAFIDI vitali64pmemail@protonmail.com
Comment-In-Reply-To: Paul Menzel paulepanter@mailbox.org
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de
Gerrit-MessageType: comment