Attention is currently required from: Christian Walter, Eric Lai, Jon Murphy, Julius Werner, Karthik Ramasubramanian, Martin L Roth, Tim Van Patten, Yu-Ping Wu.
Hello Christian Walter, Eric Lai, Julius Werner, Karthik Ramasubramanian, Tim Van Patten, Yu-Ping Wu, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/77491?usp=email
to look at the new patch set (#29).
The following approvals got outdated and were removed:
Code-Review+2 by Julius Werner, Code-Review+2 by Tim Van Patten, Verified+1 by build bot (Jenkins)
The change is no longer submittable: Code-Review and Verified are unsatisfied now.
Change subject: drivers/tpm: Add return codes to TPM driver
......................................................................
drivers/tpm: Add return codes to TPM driver
Add additional failure mode reporting to the TPM driver to provide
additional visibility into what failures are occurring.
BUG=b:296439237
TEST=Verify code paths on Skyrim, ensure behavior is unchanged.
BRANCH=None
Change-Id: I77a653201acf1bddc1ed1e2af701c8d3dd4f0606
Signed-off-by: Jon Murphy jpmurphy@google.com
---
M src/drivers/i2c/tpm/cr50.c
M src/drivers/i2c/tpm/tpm.c
2 files changed, 10 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/77491/29
--
To view, visit
https://review.coreboot.org/c/coreboot/+/77491?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I77a653201acf1bddc1ed1e2af701c8d3dd4f0606
Gerrit-Change-Number: 77491
Gerrit-PatchSet: 29
Gerrit-Owner: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-CC: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Tim Van Patten
timvp@google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: newpatchset