Attention is currently required from: Nico Huber, Furquan Shaikh, Maulik V Vaghela, Tim Wawrzynczak, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55341 )
Change subject: drivers/intel/gma: Move extended VBT just below opregion
......................................................................
Patch Set 2: Code-Review+1
(3 comments)
Patchset:
PS2:
Looks reasonable. I'll let others take a look as well.
File src/drivers/intel/gma/opregion.c:
https://review.coreboot.org/c/coreboot/+/55341/comment/deaef2ff_9c5b2c4a
PS2, Line 271: static void opregion_add_ext_vbt(igd_opregion_t *opregion, uint8_t *ext_vbt, optionrom_vbt_t *vbt)
Does this need to be a separate function?
https://review.coreboot.org/c/coreboot/+/55341/comment/5c513c57_af7787c7
PS2, Line 288: uint32_t
`size_t` would be more accurate. `cbmem_add()` uses `u64`
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55341
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic0e255df63145409096b0b9312c6c51c05f49931
Gerrit-Change-Number: 55341
Gerrit-PatchSet: 2
Gerrit-Owner: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-CC: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Wed, 09 Jun 2021 12:23:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment