build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28719 )
Change subject: sb/amd/pi/hudson: Add SPI controller support ......................................................................
Patch Set 4:
(24 comments)
https://review.coreboot.org/#/c/28719/4/src/southbridge/amd/pi/hudson/pci_de... File src/southbridge/amd/pi/hudson/pci_devs.h:
https://review.coreboot.org/#/c/28719/4/src/southbridge/amd/pi/hudson/pci_de... PS4, Line 34: #define XHCI_PCIDEV _PCI_DEV(XHCI_DEV,XHCI_FUNC) space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/28719/4/src/southbridge/amd/pi/hudson/pci_de... PS4, Line 40: #define XHCI2_PCIDEV _PCI_DEV(XHCI2_DEV,XHCI2_FUNC) space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/28719/4/src/southbridge/amd/pi/hudson/pci_de... PS4, Line 49: #define SATA_PCIDEV _PCI_DEV(SATA_DEV,SATA_FUNC) space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/28719/4/src/southbridge/amd/pi/hudson/pci_de... PS4, Line 65: #define OHCI1_PCIDEV _PCI_DEV(OHCI1_DEV,OHCI1_FUNC) space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/28719/4/src/southbridge/amd/pi/hudson/pci_de... PS4, Line 66: #define OHCI2_PCIDEV _PCI_DEV(OHCI2_DEV,OHCI2_FUNC) space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/28719/4/src/southbridge/amd/pi/hudson/pci_de... PS4, Line 67: #define OHCI3_PCIDEV _PCI_DEV(OHCI3_DEV,OHCI3_FUNC) space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/28719/4/src/southbridge/amd/pi/hudson/pci_de... PS4, Line 68: #define OHCI4_PCIDEV _PCI_DEV(OHCI4_DEV,OHCI4_FUNC) space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/28719/4/src/southbridge/amd/pi/hudson/pci_de... PS4, Line 81: #define EHCI1_PCIDEV _PCI_DEV(EHCI1_DEV,EHCI1_FUNC) space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/28719/4/src/southbridge/amd/pi/hudson/pci_de... PS4, Line 82: #define EHCI2_PCIDEV _PCI_DEV(EHCI2_DEV,EHCI2_FUNC) space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/28719/4/src/southbridge/amd/pi/hudson/pci_de... PS4, Line 83: #define EHCI3_PCIDEV _PCI_DEV(EHCI3_DEV,EHCI3_FUNC) space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/28719/4/src/southbridge/amd/pi/hudson/pci_de... PS4, Line 90: #define SMBUS_PCIDEV _PCI_DEV(SMBUS_DEV,SMBUS_FUNC) space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/28719/4/src/southbridge/amd/pi/hudson/pci_de... PS4, Line 98: #define IDE_PCIDEV _PCI_DEV(IDE_DEV,IDE_FUNC) space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/28719/4/src/southbridge/amd/pi/hudson/pci_de... PS4, Line 106: #define HDA_PCIDEV _PCI_DEV(HDA_DEV,HDA_FUNC) space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/28719/4/src/southbridge/amd/pi/hudson/pci_de... PS4, Line 114: #define LPC_PCIDEV _PCI_DEV(LPC_DEV,LPC_FUNC) space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/28719/4/src/southbridge/amd/pi/hudson/pci_de... PS4, Line 121: #define SB_PCI_PORT_PCIDEV _PCI_DEV(SB_PCI_PORT_DEV,SB_PCI_PORT_FUNC) space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/28719/4/src/southbridge/amd/pi/hudson/pci_de... PS4, Line 128: #define SD_PCIDEV _PCI_DEV(SD_DEV,SD_FUNC) space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/28719/4/src/southbridge/amd/pi/hudson/pci_de... PS4, Line 145: #define SB_PCIE_PORT1_PCIDEV _PCI_DEV(SB_PCIE_DEV,SB_PCIE_PORT1_FUNC) space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/28719/4/src/southbridge/amd/pi/hudson/pci_de... PS4, Line 146: #define SB_PCIE_PORT2_PCIDEV _PCI_DEV(SB_PCIE_DEV,SB_PCIE_PORT2_FUNC) space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/28719/4/src/southbridge/amd/pi/hudson/pci_de... PS4, Line 147: #define SB_PCIE_PORT3_PCIDEV _PCI_DEV(SB_PCIE_DEV,SB_PCIE_PORT3_FUNC) space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/28719/4/src/southbridge/amd/pi/hudson/pci_de... PS4, Line 148: #define SB_PCIE_PORT4_PCIDEV _PCI_DEV(SB_PCIE_DEV,SB_PCIE_PORT4_FUNC) space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/28719/4/src/southbridge/amd/pi/hudson/spi.c File src/southbridge/amd/pi/hudson/spi.c:
https://review.coreboot.org/#/c/28719/4/src/southbridge/amd/pi/hudson/spi.c@... PS4, Line 117: while ((spi_read8(SPI_REG_CNTRL02) & CNTRL02_EXEC_OPCODE) && trailing statements should be on next line
https://review.coreboot.org/#/c/28719/4/src/southbridge/amd/pi/hudson/spi.c@... PS4, Line 165: for (count = 0; count < bytesout; count++, dout++) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/28719/4/src/southbridge/amd/pi/hudson/spi.c@... PS4, Line 174: for (count = 0; count < bytesout; count++) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/28719/4/src/southbridge/amd/pi/hudson/spi.c@... PS4, Line 178: for (count = 0; count < bytesin; count++, din++) { braces {} are not necessary for single statement blocks
-
build bot (Jenkins) (Code Review)