Attention is currently required from: Tarun Tuli, Jamie Ryu, Wonkyu Kim, Harsha B R, Ravishankar Sarawadi, Kapil Porwal, Angel Pons, Nick Vaccaro, Tim Wawrzynczak, Raj Astekar.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66102 )
Change subject: mb/intel/mtlrvp: Add MTL-P RVP board ids ......................................................................
Patch Set 6:
(4 comments)
File src/mainboard/intel/mtlrvp/board_id.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164521): https://review.coreboot.org/c/coreboot/+/66102/comment/a5ac843b_0ce9ff9c PS6, Line 28: printk(BIOS_INFO, "id from Chrome EC 0x%x\n",(unsigned int)id); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164521): https://review.coreboot.org/c/coreboot/+/66102/comment/0dc693be_d251a84e PS6, Line 36: if ((id == 0)||(id == BOARD_ID_UNKNOWN)) { spaces required around that '||' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164521): https://review.coreboot.org/c/coreboot/+/66102/comment/fa04c3d9_0d7cc0d8 PS6, Line 37: for(int i = 0; i < 100; i++) space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164521): https://review.coreboot.org/c/coreboot/+/66102/comment/5792c1ee_8ffec725 PS6, Line 38: printk(BIOS_ERR, "Invalid board_id(0x%d). Please check" Prefixing 0x with decimal output is defective
-
build bot (Jenkins) (Code Review)