Attention is currently required from: Balaji Manigandan, Deepti Deshatty, Eric Lai, Felix Singer, Kapil Porwal, Krishna P Bhat D, Paul Menzel, Subrata Banik, Vijay P Hiremath.
Deepti Deshatty has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79211?usp=email )
Change subject: mb/intel/mtlrvp: define a new config for Chrome EC ......................................................................
Patch Set 10:
(6 comments)
File src/mainboard/intel/mtlrvp/Kconfig:
https://review.coreboot.org/c/coreboot/+/79211/comment/2d1c5086_886a225f : PS9, Line 29: select BOARD_EXT_EC_SPECIFIC_OPTIONS
select BOARD_MTLRVP_EC_GOOGLE_CHROMEEC_COMMON
I have reused the existing config BOARD_EXT_EC_SPECIFIC_OPTIONS, hope that is fine.
https://review.coreboot.org/c/coreboot/+/79211/comment/0ae0d57a_4258765e : PS9, Line 33: select SOC_INTEL_METEORLAKE_PRE_PRODUCTION_SILICON
select BOARD_MTLRVP_EC_GOOGLE_CHROMEEC_COMMON
I have reused the existing config BOARD_EXT_EC_SPECIFIC_OPTIONS, hope that is fine.
https://review.coreboot.org/c/coreboot/+/79211/comment/78c243b1_b1b8b734 : PS9, Line 38: select SOC_INTEL_METEORLAKE_PRE_PRODUCTION_SILICON
select BOARD_MTLRVP_EC_GOOGLE_CHROMEEC_COMMON
Acknowledged
https://review.coreboot.org/c/coreboot/+/79211/comment/8bd04e45_42593594 : PS9, Line 47: BOARD_MTLRVP_EC_GOOGLE_CHROMEEC_COMMON
why not below platform selects this config directly […]
Thanks. I have reused the existing config BOARD_EXT_EC_SPECIFIC_OPTIONS. Kindly check.
https://review.coreboot.org/c/coreboot/+/79211/comment/c5739a8d_fda987fc : PS9, Line 114: MTL_CHROME_EC_SHARED_SPI
please move this change into a specific CL where you are adding the support for shared SPI
Created new CL: https://review.coreboot.org/c/coreboot/+/79824/1
https://review.coreboot.org/c/coreboot/+/79211/comment/9153a5c6_21336308 : PS9, Line 121: select BOARD_MTLRVP_EC_GOOGLE_CHROMEEC_COMMON
you don't need this selection. […]
Acknowledged
-
Deepti Deshatty (Code Review)