Attention is currently required from: Hung-Te Lin, Paul Menzel, Yu-Ping Wu, Felix Held. Jianjun Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63190 )
Change subject: soc/mediatek/early_init: Fix function return type ......................................................................
Patch Set 2:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63190/comment/000fd2b9_848c7df6 PS1, Line 7: soc/mediatek: Fix function type and initialize structure to zero
soc/mediatek/early_init: Fix function return type
Done
https://review.coreboot.org/c/coreboot/+/63190/comment/026c92d3_a93216cc PS1, Line 9: function type
return type of early_init_get_elapsed_time_us()
Done
https://review.coreboot.org/c/coreboot/+/63190/comment/ee5ef75d_5c5175bd PS1, Line 9: , and : initialize structure to zero to replace memset.
Move to a separate paragraph. […]
Done
File src/soc/mediatek/common/early_init.c:
https://review.coreboot.org/c/coreboot/+/63190/comment/1556367d_7902b03a PS1, Line 34: early_init_get_elapsed_time_us
What about the caller of this (perst_time_us and min_perst_time_us in soc/mediatek/common/pcie. […]
Right, Thanks!
-
Jianjun Wang (Code Review)