Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71664 )
Change subject: src/soc/intel: Document meaning of variables
......................................................................
Patch Set 3:
(1 comment)
File src/soc/intel/alderlake/chip.h:
https://review.coreboot.org/c/coreboot/+/71664/comment/f2a737ca_083fdbee
PS2, Line 157: // Display Data Channel
Ack
It's derived from "nitpick", it means the comment is relatively straightforward to address (in most cases, the outcome is for the author to apply the suggested modifications).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/71664
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaf88f34cedd09e2461bb05050392e178ec84d5d0
Gerrit-Change-Number: 71664
Gerrit-PatchSet: 3
Gerrit-Owner: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Wed, 10 May 2023 14:03:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-MessageType: comment