Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48958 )
Change subject: soc/intel/bdw,nb/intel/hsw: convert panel delays to ms representation
......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48958/9/src/northbridge/intel/haswe...
File src/northbridge/intel/haswell/gma.c:
https://review.coreboot.org/c/coreboot/+/48958/9/src/northbridge/intel/haswe...
PS9, Line 260: reg32 |= conf->gpu_panel_power_up_delay_ms * 10 << 16 & 0x1fff0000;
Actually, still unrequired brackets...
told him so :P but it doesn't hurt so... why not :)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48958
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idf8e076dac2b3048a63a0109263a6e7899f07230
Gerrit-Change-Number: 48958
Gerrit-PatchSet: 11
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 31 Dec 2020 01:47:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment