Benjamin Doron has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/79228?usp=email )
Change subject: mb/emulation/qemu-{i440fx,q35}: Don't report ROM page tables as resource ......................................................................
mb/emulation/qemu-{i440fx,q35}: Don't report ROM page tables as resource
This is no longer required now that page tables are dynamically generated.
Change-Id: I106c1730787a88c03719acfb8a80e7b840b29997 Signed-off-by: Benjamin Doron benjamin.doron@9elements.com --- M src/mainboard/emulation/qemu-i440fx/mainboard.c M src/mainboard/emulation/qemu-q35/mainboard.c 2 files changed, 1 insertion(+), 16 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/79228/1
diff --git a/src/mainboard/emulation/qemu-i440fx/mainboard.c b/src/mainboard/emulation/qemu-i440fx/mainboard.c index 7debf8c..46f9019 100644 --- a/src/mainboard/emulation/qemu-i440fx/mainboard.c +++ b/src/mainboard/emulation/qemu-i440fx/mainboard.c @@ -31,18 +31,8 @@ } }
-static void qemu_nb_read_resources(struct device *dev) -{ - pci_dev_read_resources(dev); - - if (CONFIG(ARCH_RAMSTAGE_X86_64)) { - /* Reserve page tables in DRAM. FIXME: Remove once x86_64 page tables reside in CBMEM */ - reserved_ram_range(dev, 0, CONFIG_ARCH_X86_64_PGTBL_LOC, 6 * 0x1000); - } -} - struct device_operations nb_operations = { - .read_resources = qemu_nb_read_resources, + .read_resources = pci_dev_read_resources, .set_resources = pci_dev_set_resources, .enable_resources = pci_dev_enable_resources, .init = qemu_nb_init, diff --git a/src/mainboard/emulation/qemu-q35/mainboard.c b/src/mainboard/emulation/qemu-q35/mainboard.c index 1ff4c04..1152ccb 100644 --- a/src/mainboard/emulation/qemu-q35/mainboard.c +++ b/src/mainboard/emulation/qemu-q35/mainboard.c @@ -53,11 +53,6 @@
mmconf_resource(dev, 2);
- if (CONFIG(ARCH_RAMSTAGE_X86_64)) { - /* Reserve page tables in DRAM. FIXME: Remove once x86_64 page tables reside in CBMEM */ - reserved_ram_range(dev, 0, CONFIG_ARCH_X86_64_PGTBL_LOC, 6 * 0x1000); - } - smm_region(&tseg_base, &tseg_size); reserved_ram_range(dev, ESMRAMC, tseg_base, tseg_size); }