Change in coreboot[master]: mb/google/volteer: Remove RIPTO support for camera

[Daniel Kang (Code Review)]

Daniel Kang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46826 )

Change subject: mb/google/volteer: Remove RIPTO support for camera
......................................................................

mb/google/volteer: Remove RIPTO support for camera

GPIO D4 was used for camera reset for both front and rear cameras
(RCAM_RST_L/FCAM_RST_L) in RIPTO. For later volteer versions,
GPIO F15 is dedicated to the rear camera reset (RCAM_RST_L).

Before, BOARD_GOOGLE_VOLTEER flag was used for setting the right
RCAM_RST_L per volteer version. However, we don't support RIPTO
anymore. Also using flags for different volteer version support can
be error-prone. Removing RIPTO support.

BUG=b:171726823
BRANCH=none
TEST=Build and boot volteer proto2 or later version. Camera should
work without an issue.

Signed-off-by: Daniel Kang 
Change-Id: I961fc17092887b4807c12c95f7139bb7e7b33e91
---
M src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl
1 file changed, 0 insertions(+), 12 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/46826/1

diff --git a/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl b/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl
index a90a62e..bda0d11 100644
--- a/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl
+++ b/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl
@@ -156,11 +156,7 @@
    		MCON(3,1) /* Clock 3, 19.2MHz */

/* Pull RST low */
-#if CONFIG(BOARD_GOOGLE_VOLTEER)
    		CTXS(GPP_F15)
-#else
-			CTXS(GPP_D4)
-#endif

/* Pull SNRPWR_EN high */
    		STXS(GPP_H14)
@@ -175,11 +171,7 @@
    		REFC = REFC + 1

/* Pull RST high */
-#if CONFIG(BOARD_GOOGLE_VOLTEER)
    		STXS(GPP_F15)
-#else
-			STXS(GPP_D4)
-#endif

Sleep(1) /* t2 */

@@ -192,11 +184,7 @@
    		MCOF(3) /* Clock 3 */

/* Pull RST low */
-#if CONFIG(BOARD_GOOGLE_VOLTEER)
    		CTXS(GPP_F15)
-#else
-			CTXS(GPP_D4)
-#endif

If ((REFC == 1))
    		{

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46826 )

Change subject: mb/google/volteer: Remove RIPTO support for camera
......................................................................

Patch Set 1: Code-Review+2

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46826 )

Change subject: mb/google/volteer: Remove RIPTO support for camera
......................................................................

Patch Set 1: Code-Review+2

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46826 )

Change subject: mb/google/volteer: Remove RIPTO support for camera
......................................................................

Patch Set 1:

Needs a rebase

[Daniel Kang (Code Review)]

Hello build bot (Jenkins), Tian Shu Qiu, Patrick Georgi, Wonkyu Kim, Paul Menzel, Angel Pons, Tim Wawrzynczak, Aaron Durbin, Tomasz Figa, Elyes HAOUAS, Caveh Jalali, Tim Wawrzynczak, Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46826

to look at the new patch set (#2).

Change subject: mb/google/volteer: Remove RIPTO support for camera
......................................................................

mb/google/volteer: Remove RIPTO support for camera

GPIO D4 was used for camera reset for both front and rear cameras
(RCAM_RST_L/FCAM_RST_L) in RIPTO. For later volteer versions,
GPIO F15 is dedicated to the rear camera reset (RCAM_RST_L).

Before, BOARD_GOOGLE_VOLTEER flag was used for setting the right
RCAM_RST_L per volteer version. However, we don't support RIPTO
anymore. Also using flags for different volteer version support can
be error-prone. Removing RIPTO support.

BUG=b:171726823
BRANCH=none
TEST=Build and boot volteer proto2 or later version. Camera should
work without an issue.

Signed-off-by: Daniel Kang 
Change-Id: I961fc17092887b4807c12c95f7139bb7e7b33e91
---
M src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl
1 file changed, 1 insertion(+), 12 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/46826/2

[Daniel Kang (Code Review)]

Daniel Kang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46826 )

Change subject: mb/google/volteer: Remove RIPTO support for camera
......................................................................

Patch Set 2:
> Patch Set 1:
>
> Needs a rebase

Done. Thank you Tim.

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46826 )

Change subject: mb/google/volteer: Remove RIPTO support for camera
......................................................................

Patch Set 2: Code-Review+2

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46826 )

Change subject: mb/google/volteer: Remove RIPTO support for camera
......................................................................

Patch Set 2: Code-Review+2

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46826 )

Change subject: mb/google/volteer: Remove RIPTO support for camera
......................................................................

mb/google/volteer: Remove RIPTO support for camera

GPIO D4 was used for camera reset for both front and rear cameras
(RCAM_RST_L/FCAM_RST_L) in RIPTO. For later volteer versions,
GPIO F15 is dedicated to the rear camera reset (RCAM_RST_L).

Before, BOARD_GOOGLE_VOLTEER flag was used for setting the right
RCAM_RST_L per volteer version. However, we don't support RIPTO
anymore. Also using flags for different volteer version support can
be error-prone. Removing RIPTO support.

BUG=b:171726823
BRANCH=none
TEST=Build and boot volteer proto2 or later version. Camera should
work without an issue.

Signed-off-by: Daniel Kang 
Change-Id: I961fc17092887b4807c12c95f7139bb7e7b33e91
Reviewed-on: https://review.coreboot.org/c/coreboot/+/46826
Reviewed-by: Angel Pons 
Reviewed-by: Tim Wawrzynczak 
Tested-by: build bot (Jenkins) 
---
M src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl
1 file changed, 1 insertion(+), 12 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Angel Pons: Looks good to me, approved
  Tim Wawrzynczak: Looks good to me, approved

diff --git a/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl b/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl
index 38cf14a..d0d1c28 100644
--- a/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl
+++ b/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl
@@ -157,11 +157,7 @@
    		MCON(3,1) /* Clock 3, 19.2MHz */

/* Pull RST low */
-#if CONFIG(BOARD_GOOGLE_VOLTEER)
    		CTXS(GPP_F15)
-#else
-			CTXS(GPP_D4)
-#endif

/* Pull SNRPWR_EN high */
    		STXS(GPP_H14)
@@ -176,11 +172,8 @@
    		REFC++

/* Pull RST high */
-#if CONFIG(BOARD_GOOGLE_VOLTEER)
    		STXS(GPP_F15)
-#else
-			STXS(GPP_D4)
-#endif
+
    		Sleep(1) /* t2 */

STA = 1
@@ -192,11 +185,7 @@
    		MCOF(3) /* Clock 3 */

/* Pull RST low */
-#if CONFIG(BOARD_GOOGLE_VOLTEER)
    		CTXS(GPP_F15)
-#else
-			CTXS(GPP_D4)
-#endif

If (REFC == 1)
    		{