[XS] Change in coreboot[master]: libpayload/drivers/usb/xhci.c: Check for NULL in xhci_init - coreboot-gerrit

6 Jun 2023


      Attention is currently required from: Felix Held, Fred Reitberger.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75645?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: libpayload/drivers/usb/xhci.c: Check for NULL in xhci_init
......................................................................
Patch Set 1:
(1 comment)
File payloads/libpayload/drivers/usb/xhci.c:
https://review.coreboot.org/c/coreboot/+/75645/comment/f1a51b64_8a3b8ac5 :
PS1, Line 158: if (!physical_bar)
             : 		goto _exit_xhci;
Why is it an issue only now? Why did none of the previous platforms hit this issue?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/75645?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I05c32612606793adcba3f4a5724092387a215d41
Gerrit-Change-Number: 75645
Gerrit-PatchSet: 1
Gerrit-Owner: Fred Reitberger reitbergerfred@gmail.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Jon Murphy jpmurphy@google.com
Gerrit-Reviewer: Martin L Roth gaumless@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Karthik Ramasubramanian kramasub@google.com
Gerrit-Attention: Fred Reitberger reitbergerfred@gmail.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 05 Jun 2023 23:44:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment