Attention is currently required from: Bora Guvendik, Anil Kumar K, Selma Bensaid, Tim Wawrzynczak, Balaji Manigandan. Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63240 )
Change subject: libpayload/defconfig: enable vboot Lib Build ......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63240/comment/a17a6c30_8900ffbb PS3, Line 9: #3461454
Does it mean CONFIG_LP_CHROMEOS=y has to be set in depthcharge board/<BOARD>/defconfig ?
It's depthcharge-specific config, it does not affect libpayload at all (and should not contain CONFIG_LP_* entries anyway). Depthcharge includes libpayload's config.h/.config, which was generated and installed in it's build environment (ChromeOS SDK). In CrOS-SDK libpayloads' configs contain CONFIG_LP_CHROMEOS=y. Setting it in depthcharge/board/<BOARD>/defconfig will not change anything in libpayload, because it is compiled before depthcharge.
So, depthcharge should be build with libpayload compiled with CONFIG_LP_CHROMEOS=y, which will enable CONFIG_LP_LIB_VBOOT=y and some other things required by it. But it does not mean, that these components should be in defconfig. vBoot is not required by other payloads and I do not think that it will change soon. It would create unnecessary overhead for others using libpayload.
If you want to build any payload, you have to tune config for it. defconfig is here to make libpayload usable for general cases, and depthcharge is not one of them.
-
Jakub Czapiga (Code Review)