Change in coreboot[master]: soc/intel/broadwell/gma.c: Align `igd_setup_panel` with Haswell
Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46688 )
Change subject: soc/intel/broadwell/gma.c: Align `igd_setup_panel` with Haswell ......................................................................
soc/intel/broadwell/gma.c: Align `igd_setup_panel` with Haswell
Rename it, add a print and factor out refclock value into a variable.
Change-Id: I7248e0b54cd6310cf74eadc5d976a8868cf822f2 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/soc/intel/broadwell/gma.c 1 file changed, 10 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/46688/1
diff --git a/src/soc/intel/broadwell/gma.c b/src/soc/intel/broadwell/gma.c index ba453cdb2..8ccd278 100644 --- a/src/soc/intel/broadwell/gma.c +++ b/src/soc/intel/broadwell/gma.c @@ -281,7 +281,7 @@ return 0; }
-static void igd_setup_panel(struct device *dev) +static void gma_setup_panel(struct device *dev) { config_t *conf = config_of(dev); u32 reg32; @@ -326,7 +326,8 @@ Reference clock is 24MHz. We can choose either a 16 or a 128 step increment. Use 16 if we would have less than 100 steps otherwise. */ - const unsigned int hz_limit = 24 * 1000 * 1000 / 128 / 100; + const unsigned int refclock = 24 * MHz; + const unsigned int hz_limit = refclock / 128 / 100; unsigned int pwm_increment, pwm_period; u32 south_chicken2;
@@ -340,7 +341,12 @@ } gtt_write(SOUTH_CHICKEN2, south_chicken2);
- pwm_period = 24 * 1000 * 1000 / pwm_increment / conf->gpu_pch_backlight_pwm_hz; + pwm_period = refclock / pwm_increment / conf->gpu_pch_backlight_pwm_hz; + printk(BIOS_INFO, + "GMA: Setting backlight PWM frequency to %uMHz / %u / %u = %uHz\n", + refclock / MHz, pwm_increment, pwm_period, + DIV_ROUND_CLOSEST(refclock, pwm_increment * pwm_period)); + /* Start with a 50% duty cycle. */ gtt_write(BLC_PWM_PCH_CTL2, pwm_period << 16 | pwm_period / 2);
@@ -532,7 +538,7 @@ gtt_write(0xa008, rp1_gfx_freq << 24);
/* Post VBIOS panel setup */ - igd_setup_panel(dev); + gma_setup_panel(dev);
/* Initialize PCI device, load/execute BIOS Option ROM */ pci_dev_init(dev);
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46688
to look at the new patch set (#4).
Change subject: soc/intel/broadwell/gma.c: Align `igd_setup_panel` with Haswell ......................................................................
soc/intel/broadwell/gma.c: Align `igd_setup_panel` with Haswell
Rename it, add a print and factor out refclock value into a variable.
Change-Id: I7248e0b54cd6310cf74eadc5d976a8868cf822f2 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/soc/intel/broadwell/gma.c 1 file changed, 10 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/46688/4
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46688 )
Change subject: soc/intel/broadwell/gma.c: Align `igd_setup_panel` with Haswell ......................................................................
Patch Set 4: Code-Review+2
Hello build bot (Jenkins), Nico Huber, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46688
to look at the new patch set (#5).
Change subject: soc/intel/broadwell/gma.c: Align `igd_setup_panel` with Haswell ......................................................................
soc/intel/broadwell/gma.c: Align `igd_setup_panel` with Haswell
Rename it, add a print and factor out refclock value into a variable.
Change-Id: I7248e0b54cd6310cf74eadc5d976a8868cf822f2 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/soc/intel/broadwell/gma.c 1 file changed, 10 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/46688/5
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46688 )
Change subject: soc/intel/broadwell/gma.c: Align `igd_setup_panel` with Haswell ......................................................................
soc/intel/broadwell/gma.c: Align `igd_setup_panel` with Haswell
Rename it, add a print and factor out refclock value into a variable.
Change-Id: I7248e0b54cd6310cf74eadc5d976a8868cf822f2 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/46688 Reviewed-by: Nico Huber nico.h@gmx.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/intel/broadwell/gma.c 1 file changed, 10 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/src/soc/intel/broadwell/gma.c b/src/soc/intel/broadwell/gma.c index ba453cdb2..8ccd278 100644 --- a/src/soc/intel/broadwell/gma.c +++ b/src/soc/intel/broadwell/gma.c @@ -281,7 +281,7 @@ return 0; }
-static void igd_setup_panel(struct device *dev) +static void gma_setup_panel(struct device *dev) { config_t *conf = config_of(dev); u32 reg32; @@ -326,7 +326,8 @@ Reference clock is 24MHz. We can choose either a 16 or a 128 step increment. Use 16 if we would have less than 100 steps otherwise. */ - const unsigned int hz_limit = 24 * 1000 * 1000 / 128 / 100; + const unsigned int refclock = 24 * MHz; + const unsigned int hz_limit = refclock / 128 / 100; unsigned int pwm_increment, pwm_period; u32 south_chicken2;
@@ -340,7 +341,12 @@ } gtt_write(SOUTH_CHICKEN2, south_chicken2);
- pwm_period = 24 * 1000 * 1000 / pwm_increment / conf->gpu_pch_backlight_pwm_hz; + pwm_period = refclock / pwm_increment / conf->gpu_pch_backlight_pwm_hz; + printk(BIOS_INFO, + "GMA: Setting backlight PWM frequency to %uMHz / %u / %u = %uHz\n", + refclock / MHz, pwm_increment, pwm_period, + DIV_ROUND_CLOSEST(refclock, pwm_increment * pwm_period)); + /* Start with a 50% duty cycle. */ gtt_write(BLC_PWM_PCH_CTL2, pwm_period << 16 | pwm_period / 2);
@@ -532,7 +538,7 @@ gtt_write(0xa008, rp1_gfx_freq << 24);
/* Post VBIOS panel setup */ - igd_setup_panel(dev); + gma_setup_panel(dev);
/* Initialize PCI device, load/execute BIOS Option ROM */ pci_dev_init(dev);
-
Angel Pons (Code Review) -
Nico Huber (Code Review)