[S] Change in coreboot[main]: lib: Add GCD function - coreboot-gerrit

1 Nov 2023


      Attention is currently required from: Arthur Heymans, Julius Werner, Paul Menzel, Yidi Lin.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78798?usp=email )
Change subject: lib: Add GCD function
......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS2: 
Can we add some tests?
File src/commonlib/bsd/gcd.c:
https://review.coreboot.org/c/coreboot/+/78798/comment/6248e1e9_20110851 :
PS2, Line 6: unsigned long gcd(unsigned long a, unsigned long b)
Change to uint64_t to allow larger values?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/78798?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I21819cda4299b3809b8ca7a95cbdc6a87e4b3481
Gerrit-Change-Number: 78798
Gerrit-PatchSet: 2
Gerrit-Owner: Yidi Lin yidilin@google.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Yidi Lin yidilin@google.com
Gerrit-Comment-Date: Wed, 01 Nov 2023 14:43:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment