Change in coreboot[master]: soc/intel/common/block/acpi: add code for CPPC entries generation
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45535 )
Change subject: soc/intel/common/block/acpi: add code for CPPC entries generation ......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45535/8/src/soc/intel/common/block/... File src/soc/intel/common/block/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/45535/8/src/soc/intel/common/block/... PS8, Line 370: core Is this `virtual core` aka. thread? Otherwise it would seem that this is run twice per package in the HT case. If it's going to be the apic id, we could also name it like that.
https://review.coreboot.org/c/coreboot/+/45535/8/src/soc/intel/common/block/... PS8, Line 372: /* version 2 */ Is the comment really necessary? If you want to name arguments, you could pass a struct.
-
Nico Huber (Code Review)