Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/26346 )
Change subject: src/arch/x86: Use core apic id to get cpu_index()
......................................................................
Patch Set 14:
(1 comment)
https://review.coreboot.org/#/c/26346/14/src/arch/x86/cpu.c
File src/arch/x86/cpu.c:
https://review.coreboot.org/#/c/26346/14/src/arch/x86/cpu.c@338
PS14, Line 338: int lapic_id = lapicid();
The LAPIC id may have been changed, at least `cpu/amd/family_10h-
family_15h/init_cpus.c` does that. Better use cpuid leaf 1 info
here too.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/26346
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I55023a3e0cf42f0496d45bc6af8ead447f402350
Gerrit-Change-Number: 26346
Gerrit-PatchSet: 14
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Comment-Date: Fri, 10 May 2019 09:12:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment