Attention is currently required from: Andy Ebrahiem, Henry Barnor, Kapil Porwal, Paul Menzel, Pranava Y N, Subrata Banik.
Jayvik Desai has posted comments on this change by Jayvik Desai. ( https://review.coreboot.org/c/coreboot/+/86480?usp=email )
Change subject: google/fatcat/var/fatcat: Update GSPI0 CS pin ......................................................................
Patch Set 6:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/86480/comment/7bdb59e6_57631905?usp... : PS5, Line 9: TouchPad
touchpad
Acknowledged
https://review.coreboot.org/c/coreboot/+/86480/comment/bc3308fa_dfb4bfd3?usp... : PS5, Line 11: This commit moves the FPS GSPI0-CS signal to GPP_E17, which is an GSPI-0 CS alternative option
Please wrap the line, and add a dot/period at the end.
Acknowledged
https://review.coreboot.org/c/coreboot/+/86480/comment/be7bc9f6_c5df9709?usp... : PS5, Line 12:
Please document the schematic version.
Acknowledged
https://review.coreboot.org/c/coreboot/+/86480/comment/3b309da1_bfeadd71?usp... : PS5, Line 14: TEST=build fatcat
No run-time test?
Unfortunately I can't perform a run-time test, instead it will be performed and verified by @hbarnor@chromium.org, they'll provide there +2.
Thanks