[S] Change in coreboot[main]: vendorcode/google/chromeos: Use unsigned int for "factory_config" - coreboot-gerrit

4 Jan 2024


      Attention is currently required from: Eric Lai, Julius Werner, Kapil Porwal, Shelley Chen, Tim Van Patten.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79769?usp=email )
Change subject: vendorcode/google/chromeos: Use unsigned int for "factory_config"
......................................................................
Patch Set 4:
(1 comment)
File src/vendorcode/google/chromeos/chromeos.h:
https://review.coreboot.org/c/coreboot/+/79769/comment/2ed0305a_e0e627c4 :
PS3, Line 20: CHROMEOS_ERROR
...
But it is not something that should be used more widely? It is specifically only for functions that  […]
Acknowledged
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/79769?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3021b8646de4750b4c8e2a2981f42500894fa2d0
Gerrit-Change-Number: 79769
Gerrit-PatchSet: 4
Gerrit-Owner: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Eric Lai ericllai@google.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Kapil Porwal kapilporwal@google.com
Gerrit-Reviewer: Shelley Chen shchen@google.com
Gerrit-Reviewer: Tim Van Patten timvp@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Shelley Chen shchen@google.com
Gerrit-Attention: Eric Lai ericllai@google.com
Gerrit-Attention: Kapil Porwal kapilporwal@google.com
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Attention: Tim Van Patten timvp@google.com
Gerrit-Comment-Date: Thu, 04 Jan 2024 17:57:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik subratabanik@google.com
Comment-In-Reply-To: Julius Werner jwerner@chromium.org
Gerrit-MessageType: comment