Attention is currently required from: Bora Guvendik, Jamie Ryu, Kane Chen, Subrata Banik.
Cliff Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77614?usp=email )
Change subject: soc/intel/common: Add functions for getting address bits taken by MKTME ......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/common/block/cpu/cpulib.c:
https://review.coreboot.org/c/coreboot/+/77614/comment/fc05a820_7795ca43 : PS1, Line 504: get_tme_bit_size
cpu_common.c only contains 'cpuid' related and does not include msr header (i.e. intel soc msr. […]
okay. The following headers will be needed: #include <cpu/x86/msr.h> -> for msr_t & rdmsr() #include <cpu/intel/msr.h> -> for TME_ACTIVATE defines #include <intelblocks/cpulib.h> -> for is_tme_supported()
Also, CPU_SUPPORTS_INTEL_TME and INTEL_TME are defined in src/soc/intel/common/block/cpu/Kconfig. INTEL_TME depends on CPU_SUPPORTS_INTEL_TME and is used alone with is_tme_supported() calls as condition, although these two Kconfig variables are not used to include any additional source for building.
The TME_ACTIVATE can also be located in cpu/x86/msr.h. and the second include can be removed. still one intel-specific header from cpulib left. wondering if is_tme_supported() is generic enough to be moved.