Attention is currently required from: Jakub Czapiga, Angel Pons.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68979 )
Change subject: cpu: Add SPDX license headers to Makefiles ......................................................................
Patch Set 2:
(2 comments)
File src/cpu/amd/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/68979/comment/6a634666_86510db5 PS1, Line 1: ##
One hash sign should be enough. […]
This is just following the existing changes. There were already 600+ files using the double hash before I started. But I've gotten lots of comments about it, so maybe I'll do a cleanup patch that fixes it across the codebase.
https://review.coreboot.org/c/coreboot/+/68979/comment/77563a7e_63041c25 PS1, Line 1: ## SPDX-License-Identifier: GPL-2.0-only
+1
I agree as well, but the SPDX license header is really to be machine readable. Like the single hash, I'll fix this in a follow-on patch across the entire codebase before I start work on the Kconfig files.
-
Martin L Roth (Code Review)