Attention is currently required from: Elyes Haouas.
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62362 )
Change subject: treewide: Drop unused Kconfig symbols
......................................................................
Patch Set 13:
(1 comment)
File src/mainboard/portwell/m107/Kconfig:
https://review.coreboot.org/c/coreboot/+/62362/comment/7de695da_1756bf3d
PS11, Line 22: config ONBOARD_MEM_SAMSUNG
isn't default ONBOARD_MEM_MICRON ? […]
I agree that my comment might be confusing. In the mentioned function default is Samsung, if no other values are set.
But config default is ONBOARD_MEM_MICRON.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62362
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I96380d4567356c81e17de469fd78cec2fcb7e5c9
Gerrit-Change-Number: 62362
Gerrit-PatchSet: 13
Gerrit-Owner: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Erik van den Bogaert
ebogaert@eltan.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Tue, 08 Nov 2022 14:44:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Frans Hendriks
fhendriks@eltan.com
Comment-In-Reply-To: Elyes Haouas
ehaouas@noos.fr
Gerrit-MessageType: comment