Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35734 )
Change subject: intel/fsp_broadwell_de: Rename from xx_DEV_FUNC
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/35734/1/src/soc/intel/fsp_broadwell...
File src/soc/intel/fsp_broadwell_de/include/soc/pci_devs.h:
https://review.coreboot.org/c/coreboot/+/35734/1/src/soc/intel/fsp_broadwell...
PS1, Line 53: #define PCH_DEVFN_VTD PCI_DEVFN(VTD_DEV, VTD_FUNC)
PCH_, SCH_, something else for prefix?
VTD is directly located in the internal "Integrated I/O" block. Maybe use IIO as prefix?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35734
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1a8675a4e613a8efc135b05cde36f166acaa7ed4
Gerrit-Change-Number: 35734
Gerrit-PatchSet: 3
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 04 Oct 2019 04:19:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment