Elyes HAOUAS has posted comments on this change. ( https://review.coreboot.org/28909 )
Change subject: nb/intel/{gm45,i945,pineview}: Use macro instead of GGC address
......................................................................
Patch Set 2:
(1 comment)
regarding the datasheet, it is 16bits.
by the way, there is a conflict with this change : https://review.coreboot.org/#/c/coreboot/+/17645/
so maybe I have to keep only changes related to pineview and i945.
--
To view, visit
https://review.coreboot.org/28909
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I233e835180fd445961b6deb74ea7afc2821c236e
Gerrit-Change-Number: 28909
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes HAOUAS
ehaouas@noos.fr
Gerrit-Reviewer: Elyes HAOUAS
ehaouas@noos.fr
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 04 Oct 2018 14:42:36 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No