Attention is currently required from: Vinod Polimera, Douglas Anderson. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52959 )
Change subject: drivers/sn65dsi86: Switch EDID reading to use "indirect mode" ......................................................................
Patch Set 6:
(1 comment)
File src/drivers/ti/sn65dsi86bridge/sn65dsi86bridge.c:
https://review.coreboot.org/c/coreboot/+/52959/comment/62c69976_cde9c204 PS5, Line 253: if (i2c_writeb(bus, chip, SN_AUX_CMD_REG, AUX_CMD_SEND | (cmd << 4)) || : !wait_ms(100, !i2c_readb(bus, chip, SN_AUX_CMD_REG, &buf) && : !(buf & AUX_CMD_SEND)) || : i2c_readb(bus, chip, SN_AUX_CMD_STATUS_REG, &buf) || : (buf & (NAT_I2C_FAIL | AUX_SHORT | AUX_DFER | AUX_RPLY_TOUT))) { : printk(BIOS_ERR, "ERROR: aux command send failed\n"); : return CB_ERR; : }
If it were me, I wouldn't have written separate commands. […]
Updated the error handling. Let's ignore the SHORT issue until we actually see it be a problem, I don't see any reason why this should happen in practice.