[S] Change in coreboot[main]: mb/google/geralt: Adjust VSP/VSN voltage for CSOT_PNA957QT1_1 panel

[Yang Wu (Code Review)]

Attention is currently required from: Hung-Te Lin, Paul Menzel, Xinxiong Xu, Yidi Lin, Yu-Ping Wu, cong yang.

Yang Wu has posted comments on this change by Yang Wu. ( https://review.coreboot.org/c/coreboot/+/86640?usp=email )

Change subject: mb/google/geralt: Adjust VSP/VSN voltage for CSOT_PNA957QT1_1 panel
......................................................................

Patch Set 5:

(5 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/86640/comment/76410a28_320037da?usp... :
PS3, Line 15: TEST=Boot to firmware screen
> To the recovery screen? […]

Before modifying the voltage, there may be some screen flickering after the kernel boot. And the kernel driver cannot modify this voltage.

File src/mainboard/google/geralt/panel_ciri.c:

https://review.coreboot.org/c/coreboot/+/86640/comment/bbfa9495_72d3e46d?usp... :
PS3, Line 11: val
> Maybe more descriptive: voltage_reg_val or so?

Done

https://review.coreboot.org/c/coreboot/+/86640/comment/ab76b8c2_92f91c54?usp... :
PS3, Line 30: default
> Name it 5_7V or so?

Done

https://review.coreboot.org/c/coreboot/+/86640/comment/1f86b1ba_7eefb8b3?usp... :
PS3, Line 32: 0x11
> Please define macros for this.

Done

https://review.coreboot.org/c/coreboot/+/86640/comment/56ebb2b7_4390ff7b?usp... :
PS3, Line 35: csot
> Name it 6V?

Done