Change in coreboot[master]: Kconfig: Remove HAVE_RAMSTAGE dependency from RELOCATABLE_RAMSTAGE
Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34198 )
Change subject: Kconfig: Remove HAVE_RAMSTAGE dependency from RELOCATABLE_RAMSTAGE ......................................................................
Kconfig: Remove HAVE_RAMSTAGE dependency from RELOCATABLE_RAMSTAGE
CONFIG_RELOCATABLE_RAMSTAGE is something more than ramstage specific kconfig hence its better to remove HAVE_RAMSTAGE dependency till stage_cache cleaner implementation lands here.
Change-Id: I3c238d727dc13014e2b77544d05099be95c22bab Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/Kconfig 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/34198/1
diff --git a/src/Kconfig b/src/Kconfig index b64fdca..2bb5bfe 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -241,7 +241,6 @@
config RELOCATABLE_RAMSTAGE bool - depends on HAVE_RAMSTAGE default !NO_RELOCATABLE_RAMSTAGE select RELOCATABLE_MODULES help
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34198 )
Change subject: Kconfig: Remove HAVE_RAMSTAGE dependency from RELOCATABLE_RAMSTAGE ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34198/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34198/1//COMMIT_MSG@9 PS1, Line 9: CONFIG_RELOCATABLE_RAMSTAGE is something more than ramstage specific If that's true, the Kconfig name should change.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34198 )
Change subject: Kconfig: Remove HAVE_RAMSTAGE dependency from RELOCATABLE_RAMSTAGE ......................................................................
Patch Set 1: Code-Review+2
Nico, visit my comments in CB:33116.
Subrata Banik has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34198 )
Change subject: Kconfig: Remove HAVE_RAMSTAGE dependency from RELOCATABLE_RAMSTAGE ......................................................................
Kconfig: Remove HAVE_RAMSTAGE dependency from RELOCATABLE_RAMSTAGE
CONFIG_RELOCATABLE_RAMSTAGE is something more than ramstage specific kconfig hence its better to remove HAVE_RAMSTAGE dependency till stage_cache cleaner implementation lands here.
Change-Id: I3c238d727dc13014e2b77544d05099be95c22bab Signed-off-by: Subrata Banik subrata.banik@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/34198 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/Kconfig 1 file changed, 0 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved
diff --git a/src/Kconfig b/src/Kconfig index b64fdca..2bb5bfe 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -241,7 +241,6 @@
config RELOCATABLE_RAMSTAGE bool - depends on HAVE_RAMSTAGE default !NO_RELOCATABLE_RAMSTAGE select RELOCATABLE_MODULES help
-
Kyösti Mälkki (Code Review) -
Nico Huber (Code Review)
-
Subrata Banik (Code Review)