Hello Angel Pons,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/47670
to review the following change.
Change subject: doc/relnotes/4.13: Fix random spelling mistakes ......................................................................
doc/relnotes/4.13: Fix random spelling mistakes
Change-Id: I7486124fbe43f15bfbbf0875a58935133639b35f Signed-off-by: Nico Huber nico.huber@secunet.com --- M Documentation/releases/coreboot-4.13-relnotes.md 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/47670/1
diff --git a/Documentation/releases/coreboot-4.13-relnotes.md b/Documentation/releases/coreboot-4.13-relnotes.md index ca64815..7de5c10 100644 --- a/Documentation/releases/coreboot-4.13-relnotes.md +++ b/Documentation/releases/coreboot-4.13-relnotes.md @@ -41,17 +41,17 @@
### New version of SMM loader
-A new version of the SMM loader which accomodates platforms with over 32 CPU +A new version of the SMM loader which accommodates platforms with over 32 CPU CPU threads. The existing version of SMM loader uses a 64K code/data segment and only a limited number of CPU threads can fit into one segment (because of save state, STM, other features, etc). This loader extends beyond -the 64K segment to accomodate additional CPUs and in theory allows as many +the 64K segment to accommodate additional CPUs and in theory allows as many CPU threads as possible limited only by SMRAM space and not by 64K. By default this loader version is disabled. Please see cpu/x86/Kconfig for more info.
### Initial support for x86_64
-The x86_64 code support has been revived and enabled for qemu. While it started +The x86_64 code support has been revived and enabled for QEMU. While it started as PoC and the only supported platform is an emulator, there's interest in enabling additional platforms. It would allow to access more than 4GiB of memory at runtime and possibly brings optimised code for faster execution times.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47670 )
Change subject: doc/relnotes/4.13: Fix random spelling mistakes ......................................................................
Patch Set 1: Code-Review+1
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47670 )
Change subject: doc/relnotes/4.13: Fix random spelling mistakes ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/47670/1/Documentation/releases/core... File Documentation/releases/coreboot-4.13-relnotes.md:
https://review.coreboot.org/c/coreboot/+/47670/1/Documentation/releases/core... PS1, Line 44: CPU : CPU double CPU
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47670 )
Change subject: doc/relnotes/4.13: Fix random spelling mistakes ......................................................................
Patch Set 1: Code-Review+1
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47670 )
Change subject: doc/relnotes/4.13: Fix random spelling mistakes ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/47670/1/Documentation/releases/core... File Documentation/releases/coreboot-4.13-relnotes.md:
https://review.coreboot.org/c/coreboot/+/47670/1/Documentation/releases/core... PS1, Line 44: CPU : CPU
double CPU
Author does not intend to fix in this change
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47670 )
Change subject: doc/relnotes/4.13: Fix random spelling mistakes ......................................................................
doc/relnotes/4.13: Fix random spelling mistakes
Change-Id: I7486124fbe43f15bfbbf0875a58935133639b35f Signed-off-by: Nico Huber nico.huber@secunet.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/47670 Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Felix Singer felixsinger@posteo.net Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M Documentation/releases/coreboot-4.13-relnotes.md 1 file changed, 3 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Felix Singer: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved
diff --git a/Documentation/releases/coreboot-4.13-relnotes.md b/Documentation/releases/coreboot-4.13-relnotes.md index 8ce35da..32116e6 100644 --- a/Documentation/releases/coreboot-4.13-relnotes.md +++ b/Documentation/releases/coreboot-4.13-relnotes.md @@ -62,11 +62,11 @@
### New version of SMM loader
-A new version of the SMM loader which accomodates platforms with over 32 CPU +A new version of the SMM loader which accommodates platforms with over 32 CPU CPU threads. The existing version of SMM loader uses a 64K code/data segment and only a limited number of CPU threads can fit into one segment (because of save state, STM, other features, etc). This loader extends beyond -the 64K segment to accomodate additional CPUs and in theory allows as many +the 64K segment to accommodate additional CPUs and in theory allows as many CPU threads as possible limited only by SMRAM space and not by 64K. By default this loader version is disabled. Please see cpu/x86/Kconfig for more info.
@@ -81,7 +81,7 @@
### Initial support for x86_64
-The x86_64 code support has been revived and enabled for qemu. While it started +The x86_64 code support has been revived and enabled for QEMU. While it started as PoC and the only supported platform is an emulator, there's interest in enabling additional platforms. It would allow to access more than 4GiB of memory at runtime and possibly brings optimised code for faster execution times.
-
Angel Pons (Code Review) -
Felix Singer (Code Review)
-
Nico Huber (Code Review)
-
Paul Menzel (Code Review)