[XL] Change in coreboot[main]: security/vboot: extract secdata_tpm{1,2}.c

[Sergii Dmytruk (Code Review)]

Attention is currently required from: Sergii Dmytruk, Yu-Ping Wu.

Hello Julius Werner, Yu-Ping Wu, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/81415?usp=email

to look at the new patch set (#2).

The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)

Change subject: security/vboot: extract secdata_tpm{1,2}.c
......................................................................

security/vboot: extract secdata_tpm{1,2}.c

Most of the original secdata_tpm.c was TPM2-specific implementation.

Just moving the code around, with trivial tweaks:
 - drop now unnecessary #ifdef directives from _factory_initialize_tpm()
 - drop leading underscore from _factory_initialize_tpm{1,2}() (external
   identifiers should not start with an underscore in C)
 - drop unused <security/vboot/tpm_common.h> include and sub-includes of
   tss.h which should be considered its part (so this isn't an indirect
   inclusion)
 - fixed formatting of RETURN_ON_FAILURE() which didn't have slashes
   aligned no matter what tab width was used

Change-Id: I0090b748d7d3b2d76a941b87b5885682fd81c4fc
Signed-off-by: Sergii Dmytruk 
---
M src/security/vboot/Makefile.mk
M src/security/vboot/secdata_tpm.c
A src/security/vboot/secdata_tpm1.c
A src/security/vboot/secdata_tpm2.c
A src/security/vboot/secdata_tpm_private.h
5 files changed, 572 insertions(+), 549 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/81415/2