David Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48845 )
Change subject: mb/google/volteer/var/voema: Disable PCIE Root Port for WLAN and SD card ......................................................................
mb/google/volteer/var/voema: Disable PCIE Root Port for WLAN and SD card
Based on latest schematic, disable PCIE Root Port for WLAN and SD card.
BUG=b:169356808 TEST=FW_NAME=voema emerge-volteer coreboot chromeos-bootimage
Signed-off-by: David Wu david_wu@quanta.corp-partner.google.com Change-Id: I2a4658a382c094c2a5b16b7acaf464f54e9897b1 --- M src/mainboard/google/volteer/variants/voema/overridetree.cb 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/48845/1
diff --git a/src/mainboard/google/volteer/variants/voema/overridetree.cb b/src/mainboard/google/volteer/variants/voema/overridetree.cb index 9efcdb2..f1883b2 100644 --- a/src/mainboard/google/volteer/variants/voema/overridetree.cb +++ b/src/mainboard/google/volteer/variants/voema/overridetree.cb @@ -9,6 +9,10 @@ register "PcieClkSrcUsage[1]" = "PCIE_CLK_NOTUSED" register "PcieClkSrcUsage[3]" = "PCIE_CLK_NOTUSED"
+ # No PCIe WLAN and SD Card + register "PcieRpEnable[6]" = "0" + register "PcieRpEnable[7]" = "0" + device domain 0 on device ref i2c0 on chip drivers/i2c/generic
David Wu has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/48845 )
Change subject: mb/google/volteer/var/voema: Disable PCIe Root Port for WLAN and SD card ......................................................................
mb/google/volteer/var/voema: Disable PCIe Root Port for WLAN and SD card
Based on latest schematic, disable PCIe Root Port for WLAN and SD card.
BUG=b:169356808 TEST=FW_NAME=voema emerge-volteer coreboot chromeos-bootimage
Signed-off-by: David Wu david_wu@quanta.corp-partner.google.com Change-Id: I2a4658a382c094c2a5b16b7acaf464f54e9897b1 --- M src/mainboard/google/volteer/variants/voema/overridetree.cb 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/48845/2
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48845 )
Change subject: mb/google/volteer/var/voema: Disable PCIe Root Port for WLAN and SD card ......................................................................
Patch Set 2: Code-Review+1
Hello build bot (Jenkins), Caveh Jalali, Tim Wawrzynczak, Paul Fagerburg, Nick Vaccaro,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48845
to look at the new patch set (#3).
Change subject: mb/google/volteer/var/voema: Disable PCIe 7 and 8 for WLAN and SD card ......................................................................
mb/google/volteer/var/voema: Disable PCIe 7 and 8 for WLAN and SD card
Based on latest schematic, disable PCIe 7 and 8 for WLAN and SD card.
BUG=b:169356808 TEST=FW_NAME=voema emerge-volteer coreboot chromeos-bootimage
Signed-off-by: David Wu david_wu@quanta.corp-partner.google.com Change-Id: I2a4658a382c094c2a5b16b7acaf464f54e9897b1 --- M src/mainboard/google/volteer/variants/voema/overridetree.cb 1 file changed, 8 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/48845/3
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48845 )
Change subject: mb/google/volteer/var/voema: Disable PCIe 7 and 8 for WLAN and SD card ......................................................................
Patch Set 3: Code-Review+2
Hung-Te Lin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48845 )
Change subject: mb/google/volteer/var/voema: Disable PCIe 7 and 8 for WLAN and SD card ......................................................................
mb/google/volteer/var/voema: Disable PCIe 7 and 8 for WLAN and SD card
Based on latest schematic, disable PCIe 7 and 8 for WLAN and SD card.
BUG=b:169356808 TEST=FW_NAME=voema emerge-volteer coreboot chromeos-bootimage
Signed-off-by: David Wu david_wu@quanta.corp-partner.google.com Change-Id: I2a4658a382c094c2a5b16b7acaf464f54e9897b1 Reviewed-on: https://review.coreboot.org/c/coreboot/+/48845 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/mainboard/google/volteer/variants/voema/overridetree.cb 1 file changed, 8 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/mainboard/google/volteer/variants/voema/overridetree.cb b/src/mainboard/google/volteer/variants/voema/overridetree.cb index 8d05c32..f612beb 100644 --- a/src/mainboard/google/volteer/variants/voema/overridetree.cb +++ b/src/mainboard/google/volteer/variants/voema/overridetree.cb @@ -5,8 +5,15 @@ # and controller 1 channel 0 and 1. register "CmdMirror" = "0x00000033"
- # Disable SRCCLKREQ1# and SRCCLKREQ3# + # Disable WLAN PCIE 7 + register "PcieRpEnable[6]" = "0" + register "PcieRpLtrEnable[6]" = "0" register "PcieClkSrcUsage[1]" = "PCIE_CLK_NOTUSED" + + # Disable SD Card PCIE 8 + register "PcieRpEnable[7]" = "0" + register "PcieRpLtrEnable[7]" = "0" + register "PcieRpHotPlug[7]" = "0" register "PcieClkSrcUsage[3]" = "PCIE_CLK_NOTUSED"
device domain 0 on