Attention is currently required from: Ravi kumar, mturney mturney, Julius Werner. Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58580 )
Change subject: qualcomm/sc7280: gpio: Support eGPIO scheme ......................................................................
Patch Set 2:
(4 comments)
File src/soc/qualcomm/common/gpio.c:
https://review.coreboot.org/c/coreboot/+/58580/comment/24c62d53_78c58362 PS2, Line 21: if ((read32(®s->cfg) >> GPIO_EGPIO_SHFT) & GPIO_EGPIO_BMSK) Seem like we can just add it to the condition above. Something like:
| (read32(®s->cfg) & GPIO_EGPIO_BMSK) << GPIO_EGPIO_SHFT)
Then you don't need to define EGPIO_CFG_EN and just make some adjustments on GPIO_EGPIO_SHFT and GPIO_EGPIO_BMSK values appropriately.
File src/soc/qualcomm/common/include/soc/gpio_common.h:
https://review.coreboot.org/c/coreboot/+/58580/comment/6afdb280_e0e6b33d PS2, Line 24: GPIO_EGPIO_BMSK GPIO_CFG_EGPIO_BMSK?
https://review.coreboot.org/c/coreboot/+/58580/comment/c91cd060_44dbf8e6 PS2, Line 39: GPIO_EGPIO_SHFT GPIO_CFG_EGPIO_SHFT?
https://review.coreboot.org/c/coreboot/+/58580/comment/85c909ef_931dfbd8 PS2, Line 87: enum egpio_cfg { Is the plan to add more fields in here in the future? Just curious why we have an enum for 1 type.