Attention is currently required from: Arthur Heymans, Arthur Heymans, Jonathan Neuschäfer, Maximilian Brune, Philipp Hug.
ron minnich has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81632?usp=email )
Change subject: riscv/opensbi: make the opensbi payload a flat binary
......................................................................
Patch Set 4:
(2 comments)
File src/arch/riscv/Makefile.mk:
https://review.coreboot.org/c/coreboot/+/81632/comment/d947e1d8_ebb157e8 :
PS4, Line 178: $(OPENSBI_CBFS)-compression := non
is it executed in place? or why not compress?
it is executed in place, it seems. So I went with not compressing.
File src/mainboard/emulation/qemu-riscv/memlayout.ld:
https://review.coreboot.org/c/coreboot/+/81632/comment/6e675b48_9dcd07e6 :
PS4, Line 9: #define ROMSTAGESIZE 0
Why this change?
the bootblock and romstage are combined in one file. I see no reason to ever go back.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81632?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I31525125e87ff5925ca82f4e48fe1191ba6326fd
Gerrit-Change-Number: 81632
Gerrit-PatchSet: 4
Gerrit-Owner: ron minnich
rminnich@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Reviewer: Jonathan Neuschäfer
j.neuschaefer@gmx.net
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: Philipp Hug
philipp@hug.cx
Gerrit-Attention: Jonathan Neuschäfer
j.neuschaefer@gmx.net
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Thu, 04 Apr 2024 23:13:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment