Attention is currently required from: Intel coreboot Reviewers, Jayvik Desai, Jérémy Compostella, Kapil Porwal, Paul Menzel, Pranava Y N, Subrata Banik, Wonkyu Kim.
Bora Guvendik has posted comments on this change by Bora Guvendik. ( https://review.coreboot.org/c/coreboot/+/84872?usp=email )
Change subject: soc/intel/pantherlake: Inject CSE TS into CBMEM timestamp table
......................................................................
Patch Set 11:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84872/comment/df64f393_6268394e?usp... :
PS9, Line 13: 992:ESE completed AUnit loading 0
Out of curiosity: Why is it 0?
CSE didn't have the time when I sent the request to get the data yet. It can get the data if we call later.
File src/soc/intel/common/block/cse/Kconfig:
https://review.coreboot.org/c/coreboot/+/84872/comment/7e800e28_bda33f9d?usp... :
PS8, Line 316: _V4
Version information comes from CSE. […]
changed to v3
File src/soc/intel/common/block/include/intelblocks/cse_telemetry_v4.h:
https://review.coreboot.org/c/coreboot/+/84872/comment/44ce0a6a_f93521ed?usp... :
PS9, Line 7:
One space.
Done
https://review.coreboot.org/c/coreboot/+/84872/comment/41de8102_b74ff059?usp... :
PS9, Line 12: SOC.PMC
Is the spelling intended?
Done
File src/soc/intel/pantherlake/cse_telemetry.c:
https://review.coreboot.org/c/coreboot/+/84872/comment/5ed533b8_0771a23f?usp... :
PS9, Line 27: timestamp_add(TS_ESE_LOAD_AUNIT_END,
Mention the renaming in the commit message?
Done, modified commit message
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84872?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie7716b8c371b82c13da1b0217dce1a16e7b95cee
Gerrit-Change-Number: 84872
Gerrit-PatchSet: 11
Gerrit-Owner: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Attention: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Pranava Y N
pranavayn@google.com
Gerrit-Comment-Date: Tue, 25 Feb 2025 23:57:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Bora Guvendik
bora.guvendik@intel.com
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org